Improve lambda scenario coverage #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
commented
Oct 8, 2019
| @@ -363,4 +432,23 @@ public void LogWarning(string message) | |||
| File.AppendAllText(_logFile, message + Environment.NewLine); | |||
| } | |||
| } | |||
|
|
|||
| class InstrumentationHelperForDebugging : InstrumentationHelper | |||
There was a problem hiding this comment.
@shargon I did this to avoid restore and make instrumentation completely debuggable
MarcoRossignoli
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #343
This code fix the issue of "false covered lines/branches" for lambda and async lambda bit complex scenario.
We've again some issue with unexpected reported branch, but for now is better than nothing.
Other solution I found trim out valid branches so for now I prefer false positive uncovered branch than covered.
cc: @driseley @tonerdo @petli @SteveGilham
@daveMueller take a look if you're interested in the intrumentation part, you can start from test, are debuggable pass true to
TestInstrumentationHelper.Run(.,disableRestoreModuleandRemoteExecutor.Invoke(...,invokeLocal), if you're in throuble let me know.