fix: handle negative infinity

tonytonyjan · Oct 2, 2017 · 51dc679 · 51dc679
1 parent b927674
commit 51dc679
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 1 deletion.
diff --git a/ext/exif/data.c b/ext/exif/data.c
@@ -211,7 +211,7 @@ VALUE srational_to_num(ExifSRational srational){
   if(srational.numerator == 0 && srational.denominator == 0)
     return DBL2NUM(NAN);
   else if(srational.denominator == 0)
-    return DBL2NUM(INFINITY);
+    return DBL2NUM(srational.numerator > 0 ? INFINITY : -INFINITY);
   else
     return rb_rational_new(LONG2NUM(srational.numerator), LONG2NUM(srational.denominator));
 }
diff --git a/test/infinity.jpg b/test/infinity.jpg
diff --git a/test/test_exif.rb b/test/test_exif.rb
@@ -230,5 +230,6 @@ def test_nan
   def test_infinity
     data = Exif::Data.new(IO.read(File.expand_path('../infinity.jpg', __FILE__)))
     assert_equal Float::INFINITY, data.exposure_index
+    assert_equal -Float::INFINITY, data.exposure_bias_value
   end
 end