Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to disable the anti-spam #11296

Merged
merged 4 commits into from
Jul 17, 2019

Conversation

ClearlyClaire
Copy link
Contributor

No description provided.

@Gargron
Copy link
Member

Gargron commented Jul 14, 2019

I would prefer if the feature was perfected in such a way that hard-disabling it would not be necessary. Although as I understand it this action is pre-emptive as nobody has complained about too many false positives yet. But either way: This method makes disabling it inaccessible to masto.host (and similar) users.

@ClearlyClaire
Copy link
Contributor Author

Good point, going to change that to an admin panel setting.

@ClearlyClaire ClearlyClaire force-pushed the fixes/disable-antispam branch from 9942c6d to 3523e6f Compare July 14, 2019 22:09
@ClearlyClaire ClearlyClaire changed the title Add environment variable to disable the anti-spam Add setting to disable the anti-spam Jul 14, 2019
@ClearlyClaire
Copy link
Contributor Author

(It has been changed)

@@ -390,6 +391,9 @@ en:
activity_api_enabled:
desc_html: Counts of locally posted statuses, active users, and new registrations in weekly buckets
title: Publish aggregate statistics about user activity
antispam_enabled:
desc_html: Mastodon can auto-silence and auto-report accoutns based on measures such as detecting accounts who send repeated unsolicited messages. There may be false positives.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in accounts

@@ -30,6 +30,7 @@ def index
@trending_hashtags = TrendingTags.get(7)
@profile_directory = Setting.profile_directory
@timeline_preview = Setting.timeline_preview
@antispam_enabled = Setting.antispam_enabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the Ruby class is called "spam_check" would it not be more consistent to name it "spam_check_enabled"? That being said it probably doesn't matter.

@ClearlyClaire ClearlyClaire force-pushed the fixes/disable-antispam branch from 7ebc1ea to dbcfede Compare July 17, 2019 00:11
@Gargron Gargron merged commit 7e2b6da into mastodon:master Jul 17, 2019
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Add environment variable to disable the anti-spam

* Move antispam setting to admin settings

* Fix typo

* antispam → spam_check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants