Fix hashtag column options styling #14247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
fixes/css-nonce
branch
from
309adf4 to
de16bd8
Compare
Gargron
approved these changes
Jul 6, 2020
ashfurrow
added a commit
to ashfurrow/mastodon
that referenced
this pull request
Jan 25, 2021
This reverts commit a783bdf. The CSP for mastodon.technology is permissive enough to prevent the bug fixed in mastodon#14247, so the nonce approach is unnecessary. In fact, it breaks some users' custom scripts. m.t appeals to coders so we should let them use browser extensions.
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Dec 7, 2022
* Enable nonces for stylesheets * Pass nonce to react-select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advanced options of the hashtag column uses react-select, which unfortunately generates its CSS rules dynamically using the emotion framework, which means it dynamically creates a CSS stylesheet from Javascript, which is broken with our current Content-Security-Policy.
This PR adds support for nonce-based stylesheets and passes the stylesheet nonce to
react-selectso it can properly include its stylesheet.This require some monkey-patching of Rails.