Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] tsd setup on @toss/react-query #86

Closed
manudeli opened this issue Oct 25, 2022 · 0 comments · Fixed by #99
Closed

[Feature] tsd setup on @toss/react-query #86

manudeli opened this issue Oct 25, 2022 · 0 comments · Fixed by #99

Comments

@manudeli
Copy link
Member

manudeli commented Oct 25, 2022 •
edited
Loading 

    @manudeli

I think you're right about seprating to next PR.

And yes, you can open an issue, and you can setup up tsd tests in whole monorepo.
But with bottom-up approach,
how about adopting tsd only in @tossteam/react-query first and do the whole thing later?

Originally posted by @changyoungoh in #73 (comment)
@manudeli manudeli changed the title [Feature] tsd setup on @toss/react-query [FEATURE] tsd setup on @toss/react-query Oct 25, 2022
@manudeli manudeli changed the title [FEATURE] tsd setup on @toss/react-query [Feature] tsd setup on @toss/react-query Oct 25, 2022
@manudeli manudeli mentioned this issue Oct 28, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(react-query): add tsd manudeli/slash
1 participant
@manudeli