Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to implement tonic::transport::NamedService for middlewares #91

Closed
davidpdrsn opened this issue May 13, 2021 · 1 comment
Closed
Labels
C-enhancement Category: A PR with an enhancement or a proposed on in an issue.

Comments

@davidpdrsn
Copy link
Member

davidpdrsn commented May 13, 2021

Tonic requires that services implement NamedService to be used with its router. I'm thinking it might be useful to have an optional feature called tonic that when enabled will add NamedService impls for all middleware as done here. Though it might require adding it to tower as well for it to actually be useful 🤔

@davidpdrsn davidpdrsn added the C-enhancement Category: A PR with an enhancement or a proposed on in an issue. label May 13, 2021
@davidpdrsn
Copy link
Member Author

I was able to find a solution in tonic that makes it easier to directly use any tower middleware without having to worry about NamedService hyperium/tonic#651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: A PR with an enhancement or a proposed on in an issue.
Projects
None yet
Development

No branches or pull requests

1 participant