Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent usage of trailing backslashes #134

Closed
ThomasWaldmann opened this issue Feb 5, 2023 · 2 comments
Closed

inconsistent usage of trailing backslashes #134

ThomasWaldmann opened this issue Feb 5, 2023 · 2 comments

Comments

@ThomasWaldmann
Copy link
Contributor

While doing #132 I noticed trailing backslashes in paths are not used consistently.

When I tried making it consistent, tests failed.

https://github.com/platformdirs/platformdirs/blob/2.6.2/src/platformdirs/macos.py

with trailing /: 19, 29

without: 23, 34, ...
@ThomasWaldmann
Copy link
Contributor Author

The test fail in tests/test_comp_with_appdirs.py can be fixed by:

    assert new == old.rstrip("/")

Looks like this bug has been inherited from appdirs.

@ThomasWaldmann
Copy link
Contributor Author

Fixed by #137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThomasWaldmann