Bugfix: Do the same transformation to egg-info dirs that pkg_resources does #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To determine whether we should re-install an egg, we look for an .egg-info directory based on the output of `setup.py --name`, but .egg-info directories have their dashes transformed into underscores by pkg_resources.to_filename. When we look for an .egg-info directory, we should apply the same transformation.
hashbrowncipher
changed the title
gaborbernat
approved these changes
Oct 10, 2018
|
Interesting that this did not generate a CI run, will need to investigate. Will follow up tomorrow. Thanks for the PR. |
gaborbernat
force-pushed
the
to_filename
branch
from
fd64feb to
b504624
Compare
gaborbernat
force-pushed
the
to_filename
branch
from
b504624 to
534a5e6
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that my hyphenated project name is not using the
develop-inst-noopaction, instead using thedevelop-inst-nodeps(cf. #910). This is because it uses a hyphenated project name, and tox was looking at the mtime of a nonexistentmyproject-name.egg-infodirectory, when distutils/setuptools instead create a directory calledmyproject_name.egg-info. I don't know why they behave this way.I've added a test for this behavior, and also made it so that initproj can take hyphenated strings for project names. Then, to fix the failing test, I added a call to
to_filename, the function whichpkg_resourcesuses for the same transformation.