-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indentation in our tox.ini and the docs #1110
Comments
I personally prefer the smaller number of lines. It's more compact and I find there's plenty of wide space on today's monitors. |
I also think having a single indentation by the equal sign makes things more readable, but that could be just me. |
My personal experience is that I prefer shorter line lengths independent of how wide my monitor is. I was really happy with Pythons PEP 8 limitation of 79 chars per line. Even with a line length of 88 (the new emerging standard thanks to black) a side by side diff is breaking up already if your eyesight is not that great (like mine) and need a bigger font. The even longer line length of the code in the tox project feels really unwieldy to me and that is also something I would like to address, but not in this issue. |
I've personally like 120, but decided to meet you half way at 99 back when we introduced black. I guess this is the place where we diverge on opinions on what is easy to read. I myself find hard to read when we try to squeeze stuff into 88 characters. |
-- me further above :) |
Well I was just putting it out that we probably would have a sharp difference of opinion would you open that issue, as it would feel like you're opening issues already discussed and settled a few months back. |
@obestwalter strong agree from my end on your preference of format. Avoids manual 13-space indents and is much easier to separate key from value. |
At least the upcoming version 4 uses Issue can be closed as soon as we support P.S.: oops, it is about the docs.... I bet @gaborbernat takes great care when migrating them via #1914 |
I just skimmed the documentation for tox4, and the indentation looks good! Though, the example section has not been moved over to the tox4 documentation. @gaborbernat What are your plans for https://tox.readthedocs.io/en/3.24.1/examples.html ? Will we have an example section for tox4, too? I am all in favor, but we'd need to go through all examples and check whether they are still valid (e.g. the subsection on nose can be omitted). |
Yeah, basically those 👍 will create a new ticket for the examples 👍 |
See #2143 |
Going through the docs I saw this:
there are two different ways of indenting multi-line values used here and all over the docs:
vs
I strongly prefer variant two not just for aesthetical reasons. I find it much easier to read. Especially for things like
the second variant is much clearer and easier to read.
The text was updated successfully, but these errors were encountered: