Avoid incompatible six #1519
Merged
Avoid incompatible six #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaborbernat
approved these changes
Feb 12, 2020
|
@gaborbernat I do see few CI failures which seem fully unrelated to my change. Are they known and not counting for final result? I raised bug at #1520 for them. I am afraid that due to their less than mainstream nature, these may end-up not being fixed for a long time. Does it makes sense to block other fixes due to them or we should maybe downgrade the support matrix for these? Given enough time we could endup with nothing merging due to a long queue of broken-unrelated bits. |
|
They are known but need to be fixed for merges. Can be this or another pr 🤷♂️ the reason I did not do this myself is that I don't have time at the moment to fix the ci. |
Merged
Avoids problem introduced by newer virtualenv which broke installation of tox on systems that already had a six version >1.0 installed but which was older than minimal needed by tox.
bmwiedemann
referenced
this pull request
in bmwiedemann/openSUSE
Mar 26, 2020
https://build.opensuse.org/request/show/786809 by user scarabeus_iv + dimstar_suse - Disable spinner tests as the monkeypatch changed behaviour in pytest - version update to 3.14.5 - Add ``--discover`` (fallback to ``TOX_DISCOVER`` environment variable via path separator) to inject python executables to try as first step of a discovery - note the executable still needs to match the environment by :user:`gaborbernat`. `#1526 <https://github.com/tox-dev/tox/issues/1526>`_ - Bump minimal six version needed to avoid using one incompatible with newer virtualenv. - by :user:`ssbarnea` `#1519 <https://github.com/tox-dev/tox/issues/1519>`_ - Avoid pypy test failure due to undefined printout var. - by :user:`ssbarnea` `#1521 <https://github.com/tox-dev/tox/issues/1521>`_
openstack-mirroring
pushed a commit
to openstack-archive/sahara
that referenced
this pull request
Jan 27, 2021
= six (and tox): the latest versions of tox (which are compatible with newer virtualenv[1][2]) require a newer six. [1] https://tox.readthedocs.io/en/latest/changelog.html#v3-14-4-2020-02-13 [2] tox-dev/tox#1519 = alembic: A newer version is required by oslo-db 6.0.0. = oslo.service: 1.24.0 (and before 1.31.0) capped eventlet to <0.21.0, but eventlet>0.26.0 is now required. = cryptography: paramiko 2.7.1 requires cryptography>=2.5.0 = oslo-messaging: bumped to 10.2.0 = greenlet: bumped to 0.4.16 to be compatible with py3.9 = warlock, amqp, pycodestyle: just drop those indirect dependencies from l-c (and in fact pycodestyle is only a dependency of a linter for testing). Change-Id: I26bd73463a5da9ef947f287610b0a33b73062417
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Jan 27, 2021
* Update sahara from branch 'master'
to f576d092b7797178e4456e495b6c00a284870bc5
- Fix lower requirements: bump various packages
= six (and tox): the latest versions of tox (which are
compatible with newer virtualenv[1][2]) require a newer six.
[1] https://tox.readthedocs.io/en/latest/changelog.html#v3-14-4-2020-02-13
[2] tox-dev/tox#1519
= alembic: A newer version is required by oslo-db 6.0.0.
= oslo.service: 1.24.0 (and before 1.31.0) capped eventlet to <0.21.0,
but eventlet>0.26.0 is now required.
= cryptography: paramiko 2.7.1 requires cryptography>=2.5.0
= oslo-messaging: bumped to 10.2.0
= greenlet: bumped to 0.4.16 to be compatible with py3.9
= warlock, amqp, pycodestyle: just drop those indirect dependencies
from l-c (and in fact pycodestyle is only a dependency of a linter
for testing).
Change-Id: I26bd73463a5da9ef947f287610b0a33b73062417
ssbarnea
added a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
Avoids problem introduced by newer virtualenv which broke installation of tox on systems that already had a six version >1.0 installed but which was older than minimal needed by tox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids problem introduced by newer virtualenv which broke installion
of tox on systems that already had a six version >1.0 installed but
which was older than minimal needed by tox.
Thanks for contributing a pull request!
If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.
Avoids installing tox with a combination of virtualenv-six that is broken, mainly introduced by newer virtualenv which dropped vendored six and which requires six>=1.14.0.
Pip fails to install correct dependency because we list six already as a dependecy. We cannot drop it but we can bump it to assure we avoid ending with incompatible setup.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc<your username>"superuser."CONTRIBUTORS(preserving alphabetical order)