Allow escaping curly braces in setenv #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkenigs
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
gaborbernat
requested changes
Aug 20, 2020
|
Should this be done after every time _replace is called or moved into _replace? |
mkenigs
force-pushed
the
escape-braces-in-setenv
branch
from
6180015 to
448cc7d
Compare
mkenigs
force-pushed
the
escape-braces-in-setenv
branch
from
448cc7d to
2e5e833
Compare
Currently braces can be escaped, but the backslashes are not removed, making it impossible to add a plain curly brace Signed-off-by: Bernat Gabor <[email protected]>
gaborbernat
force-pushed
the
escape-braces-in-setenv
branch
from
2e5e833 to
3c38762
Compare
|
@gaborbernat anything else needed for this? |
|
Released via https://pypi.org/project/tox/3.20.0/ |
tekumara
pushed a commit
to seek-oss/aec
that referenced
this pull request
Sep 4, 2020
Bumps [tox](https://github.com/tox-dev/tox) from 3.19.0 to 3.20.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tox-dev/tox/blob/master/docs/changelog.rst">tox's changelog</a>.</em></p> <blockquote> <h2>v3.20.0 (2020-09-01)</h2> <p>Bugfixes ^^^^^^^^</p> <ul> <li>Allow hyphens and empty factors in generative section name. - by :user:<code>tyagdit</code> <code>[#1636](tox-dev/tox#1636) <https://github.com/tox-dev/tox/issues/1636></code>_</li> <li>Support for PEP517 in-tree build backend-path key in <code>get-build-requires</code>. - by :user:<code>nizox</code> <code>[#1654](tox-dev/tox#1654) <https://github.com/tox-dev/tox/issues/1654></code>_</li> <li>Allow escaping curly braces in setenv. - by :user:<code>mkenigs</code> <code>[#1656](tox-dev/tox#1656) <https://github.com/tox-dev/tox/issues/1656></code>_</li> </ul> <p>Features ^^^^^^^^</p> <ul> <li>Support for comments within <code>setenv</code> and environment files via the <code>files|</code> prefix. - by :user:<code>gaborbernat</code> <code>[#1667](tox-dev/tox#1667) <https://github.com/tox-dev/tox/issues/1667></code>_</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tox-dev/tox/commit/5c94919b79105eabb0507f6d5e55b60daee11ccc"><code>5c94919</code></a> release 3.20.0</li> <li><a href="https://github.com/tox-dev/tox/commit/8a25fa6bf3e625c0b47659e1652ab55a79d4d1e8"><code>8a25fa6</code></a> Support environment files and comments in setenv (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/1668">#1668</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/a7903508fa07068b327e15cfdbf8ea330ab78765"><code>a790350</code></a> New formatters</li> <li><a href="https://github.com/tox-dev/tox/commit/d4e6e77ea77cf8b336f38313bef40c80b6771139"><code>d4e6e77</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/1656">#1656</a> from mkenigs/escape-braces-in-setenv</li> <li><a href="https://github.com/tox-dev/tox/commit/8e39dfbb836b6e2e6b2bd637f7b853935e82de3f"><code>8e39dfb</code></a> Spelling fixes (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/1665">#1665</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/00f6496b756f938db4ddcf040a5192a9e40b16a4"><code>00f6496</code></a> Document allowlist_externals versionadded (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/1663">#1663</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/3c38762fc6acfd6ca93ddc8607133d3a39e6d25c"><code>3c38762</code></a> Allow escaping curly braces in setenv</li> <li><a href="https://github.com/tox-dev/tox/commit/3453018dab9a0208f64013c2dd357d1be348ffdf"><code>3453018</code></a> Make setup.py test admonition sterner as it is deprecated (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/1660">#1660</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/4b7f682db872902b542ccaf26d9619c141dfc8ab"><code>4b7f682</code></a> remove broken link to removed pytest-runner documentation (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/1659">#1659</a>)</li> <li><a href="https://github.com/tox-dev/tox/commit/f292f5236a41f7c02ba60dbc14d8e5941be7ea0e"><code>f292f52</code></a> Fix support of the PEP517 backend-path key (<a href="https://github-redirect.dependabot.com/tox-dev/tox/issues/1655">#1655</a>)</li> <li>Additional commits viewable in <a href="https://github.com/tox-dev/tox/compare/3.19.0...3.20.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
jayvdb
added a commit
to jayvdb/tox
that referenced
this pull request
Oct 17, 2020
jayvdb
added a commit
to jayvdb/tox
that referenced
this pull request
Oct 17, 2020
jayvdb
added a commit
to jayvdb/tox
that referenced
this pull request
Oct 17, 2020
jayvdb
added a commit
to jayvdb/tox
that referenced
this pull request
Oct 17, 2020
jayvdb
added a commit
to jayvdb/tox
that referenced
this pull request
Oct 18, 2020
jayvdb
added a commit
to jayvdb/tox
that referenced
this pull request
Oct 18, 2020
jayvdb
added a commit
to jayvdb/tox
that referenced
this pull request
Oct 18, 2020
jayvdb
added a commit
to jayvdb/tox
that referenced
this pull request
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently braces can be escaped, but the backslashes are not removed,
making it impossible to add a plain curly brace
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc<your username>"superuser."CONTRIBUTORS(preserving alphabetical order)