Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parsing [testenv] sections in setup.cfg official #1727

Merged
merged 5 commits into from
Nov 5, 2020
Merged

Make parsing [testenv] sections in setup.cfg official #1727

merged 5 commits into from
Nov 5, 2020

Conversation

mauvilsa
Copy link

@mauvilsa mauvilsa commented Oct 31, 2020

Even though #1724 was reverted, I suppose that to make testenv sections in setup.cfg an official feature, there should be unit tests for it and be mentioned in the documentation. So I open this new pull request. I have modified the code so that it is backward compatible and added a unit test so that now it is tested for both [testenv] and [tox:testenv] sections.

Self-referencing #1727 since there is no issue associated to this.

Contribution checklist:

(also see CONTRIBUTING.rst for details)

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added relevant issue keyword
    in message body
  • added news fragment in changelog folder
    • fragment name: <issue number>.<type>.rst for example (588.bugfix.rst)
    • <type> is must be one of bugfix, feature, deprecation,breaking, doc, misc
    • if PR has no issue: consider creating one first or change it to the PR number after creating the PR
    • "sign" fragment with "by :user:<your username>"
    • please use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files - by :user:superuser."
    • also see examples
  • added yourself to CONTRIBUTORS (preserving alphabetical order)

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1 @@
Support parsing [tox:testenv*] sections in setup.cfg. - by :user:`mauvilsa`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the right wording here is officially/explicitly. Because the support is already there, just not spelled out.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support with the tox: prefix is not there yet.

@mauvilsa mauvilsa marked this pull request as ready for review October 31, 2020 10:07
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no, sorry, miss-understood then. We're not planning on adding new ways to do this. You can already achieve what you want via [tox] and [testenv] which should suffice. I see no reason to support yet another way.

@mauvilsa
Copy link
Author

@gaborbernat I guess you meant that we can already achieve this with [tox:tox] and [testenv]. Sure if this is what you want I can change the pull request only adding one unit test and the update of the documentation. Though I don't have time to do this right now.

@mauvilsa mauvilsa changed the title Parse [tox:testenv] sections in setup.cfg with backward compatibility Make parsing [testenv] sections in setup.cfg official Nov 3, 2020
@mauvilsa mauvilsa requested a review from gaborbernat November 3, 2020 18:58
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit fa3f78b into tox-dev:master Nov 5, 2020
ssbarnea pushed a commit to ssbarnea/tox that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants