-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make parsing [testenv] sections in setup.cfg official #1727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/changelog/1727.feature.rst
Outdated
@@ -0,0 +1 @@ | |||
Support parsing [tox:testenv*] sections in setup.cfg. - by :user:`mauvilsa` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the right wording here is officially/explicitly. Because the support is already there, just not spelled out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support with the tox:
prefix is not there yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no, sorry, miss-understood then. We're not planning on adding new ways to do this. You can already achieve what you want via [tox]
and [testenv]
which should suffice. I see no reason to support yet another way.
@gaborbernat I guess you meant that we can already achieve this with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though #1724 was reverted, I suppose that to make testenv sections in setup.cfg an official feature, there should be unit tests for it and be mentioned in the documentation. So I open this new pull request. I have modified the code so that it is backward compatible and added a unit test so that now it is tested for both
[testenv]
and[tox:testenv]
sections.Self-referencing #1727 since there is no issue associated to this.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rst
for example (588.bugfix.rst)<type>
is must be one ofbugfix
,feature
,deprecation
,breaking
,doc
,misc
<your username>
"superuser
."CONTRIBUTORS
(preserving alphabetical order)