Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let skip_install override usedevelop instead of the other way around #571

Closed
obestwalter opened this issue Aug 9, 2017 · 2 comments · Fixed by #572
Closed

Let skip_install override usedevelop instead of the other way around #571

obestwalter opened this issue Aug 9, 2017 · 2 comments · Fixed by #572
Labels
area:configuration feature:change something exists already but should behave differently help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.
Milestone
3.7

Comments

@obestwalter
Copy link
Member

obestwalter commented Aug 9, 2017 •
edited
Loading

skip_install and usedevelop can be used together in the same environment but the behaviour is not documented. If both flags are True the package will be installed although skip_install is requested (see also discussion here).

The behaviour should be changed that skip_install overrides usedevelop as usedevelop is an option to choose the installation type if the package is installed and skip_install determines if it should be installed at all.

This is a somewhat breaking change of undocumented behaviour but I think this should be done to make the behaviour intuitively correct (but it should also be documented).

It should be also stated prominently in the changelog that this changed and how it can be fixed though. The documentation should be updated mention the behaviour when these two flags are used together.
@obestwalter obestwalter added area:configuration feature:change something exists already but should behave differently labels Aug 9, 2017
@obestwalter obestwalter mentioned this issue Aug 9, 2017
Closed
@ferdonline ferdonline mentioned this issue Aug 9, 2017
Merged
@obestwalter
Copy link
Member Author

docs still needed.

@obestwalter obestwalter reopened this Sep 7, 2017
@gaborbernat gaborbernat mentioned this issue Sep 8, 2017
Merged
@goodboy goodboy mentioned this issue Jan 7, 2018
Merged
@gaborbernat gaborbernat added this to the 3.5 milestone Sep 18, 2018
@gaborbernat gaborbernat modified the milestones: 3.5, 3.6 Oct 8, 2018
@gaborbernat gaborbernat modified the milestones: 3.6, 3.7 Dec 16, 2018
@gaborbernat gaborbernat added the help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted. label May 3, 2019
@gaborbernat
Copy link
Member

This has been done with tox 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:configuration feature:change something exists already but should behave differently help:wanted Issues that have been acknowledged, a solution determined and a PR might likely be accepted.
Projects
None yet
Milestone
3.7
Development

Successfully merging a pull request may close this issue.

Fixing #571. skip_install should override usedevelop ferdonline/tox
2 participants
@obestwalter @gaborbernat