Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller service selector should be more accurate #725

Closed
jspdown opened this issue Sep 8, 2020 · 0 comments · Fixed by #726
Closed

Controller service selector should be more accurate #725

jspdown opened this issue Sep 8, 2020 · 0 comments · Fixed by #726
Labels
area/helm kind/bug/confirmed a confirmed bug (reproducible).
Milestone

Comments

@jspdown
Copy link
Contributor

jspdown commented Sep 8, 2020

Bug Report

The controller service selector is:

component: controller

We should be provide a more specific selector for this service:

app: maesh
component: controller
release: <release-name>

What did you do?

Create a pod with the label:

app: something
component: controller

What did you expect to see?

I don't expect to see this pod listed in the endpoints of the controller service

What did you see instead?

The pod was listed in the endpoints.

Output of controller log: (What version of Maesh are you using?)

Not relevant for this case

What is your environment & configuration (arguments, provider, platform, ...)?

version: latest
platform: k3s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm kind/bug/confirmed a confirmed bug (reproducible).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant