Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up cmdline arguments & defaults #21

Closed
teepark opened this issue Feb 9, 2017 · 3 comments
Closed

clean up cmdline arguments & defaults #21

teepark opened this issue Feb 9, 2017 · 3 comments

Comments

@teepark
Copy link

teepark commented Feb 9, 2017

The main package command line arguments are currently done in a mix of styles:

  • tcpaddr is an ip:port address with no default
  • raftaddr and raftport together form the bind location for the raft protocol
  • serfport is just the port with a default value -- the IP is hard-coded to 0.0.0.0.
  • raftdir is actually ignored, instead logdir/raft is always used

I propose getting rid of raftdir, and standardizing on ip:port arguments with defaults serving on all interfaces (0.0.0.0). Ideally the beginner, experimenting, can get started with a single-node cluster by just running jocko.

Would you accept a PR like this?

@travisjeffery
Copy link
Owner

Yep, I'd accept a PR. Thanks.

@travisjeffery
Copy link
Owner

Ah I ended up writing one. Let me know what you think about that. The Raft one has to be set to 127.0.0.1 and set at times when you want to advertise otherwise. Hashicorp's Consul works the same way.

@teepark
Copy link
Author

teepark commented Feb 9, 2017

Nice! I'll go ahead and make a PR from my WIP, see if there's anything worth borrowing there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants