Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presigned URL signing key should be extracted dynamically from blockstore configuration #8571

Open
N-o-Z opened this issue Jan 29, 2025 · 1 comment · May be fixed by #8573
Open

Presigned URL signing key should be extracted dynamically from blockstore configuration #8571

N-o-Z opened this issue Jan 29, 2025 · 1 comment · May be fixed by #8573
Assignees
@N-o-Z
Labels
msb

Comments

@N-o-Z
Copy link
Member

N-o-Z commented Jan 29, 2025

  • Remove signing key field from catalog
  • Extract signing key dynamically from blockstore configuration when needed based on repository (controller)
@N-o-Z N-o-Z added the msb label Jan 29, 2025
@N-o-Z N-o-Z self-assigned this Jan 29, 2025
@N-o-Z N-o-Z linked a pull request Jan 30, 2025 that will close this issue
Open
@N-o-Z N-o-Z linked a pull request Jan 30, 2025 that will close this issue
Catalog: use dynamic signing key #8573
Open
@nadavsteindler
Copy link
Contributor

@N-o-Z I'm reviewing this PR but the issue description lacks background. It's not clear to me why we are making this change or what it has to do with any ongoing projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@N-o-Z N-o-Z

Labels
msb
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Catalog: use dynamic signing key treeverse/lakeFS
2 participants
@N-o-Z @nadavsteindler