Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompletableTransformer is removed in rxjava 1.2.0 #151

Closed
hamberluo opened this issue Sep 18, 2016 · 8 comments
Closed

CompletableTransformer is removed in rxjava 1.2.0 #151

hamberluo opened this issue Sep 18, 2016 · 8 comments

Comments

@hamberluo
Copy link

No description provided.

@vanniktech
Copy link
Contributor

CompletableTransformer : renamed to Completable.Transformer

@dlew
Copy link
Contributor

dlew commented Sep 19, 2016

Oh neat, so there's no way for the library to be backwards compatible. :P

@vanniktech
Copy link
Contributor

They were able to make that change since Completable was marked as Experimental

@dlew
Copy link
Contributor

dlew commented Sep 19, 2016

I know, I think I've learned a lesson here not to support experimental APIs in a more stable lib.

The problem is that people wanted support for completable/etc...

@markrietveld
Copy link

I wouldn't worry about it. People using using CompletableTransformer would have had to make this change regardless of this library, and people not using CompletableTransformer shouldn't have upgrade issues, right?

@dlew
Copy link
Contributor

dlew commented Sep 19, 2016

I'm not 100% sure, but I think that even if you're not using Completable.Transformer it's used in the source code of RxLifecycle. So unless you're proguarding all that stuff out, the compiler will complain that RxLifecycle is referencing classes that don't exist.

@markrietveld
Copy link

markrietveld commented Sep 19, 2016

I think it won't complain, since RxLifecycle will already have been compiled by the time gradle downloads it. I'll try it after you release 0.8.0 and let you know. The inverse (Using RxJava 1.2 with RxLifecycle 0.7) compiles and works fine if I don't use CompletableTransformer.

@markrietveld
Copy link

Confirming: I don't use CompletableTransformer, and RxLifecycle 0.8.0 compiles and works for me with RxJava 1.1.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants