Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest version(0.3.1) cause a lot of type convert error while compiling #63

Closed
simpleton opened this issue Dec 3, 2015 · 2 comments

Comments

@simpleton
Copy link

It works well in version 0.3.0.
Here is my code snippet:

 feedService.getTopicFeedList(groupId, loadPage)
            .compose(this.bindToLifecycle())
            .subscribe(
                feedDetails -> {
                    BannerFeedsAdapter adapter = (BannerFeedsAdapter) recyclerView.getAdapter();
                    if (adapter == null) {
                        adapter = new BannerFeedsAdapter(BannerFeedsActivity.this, feedDetails, bannerUrl, isContainBanner);
                        recyclerView.setAdapter(adapter);
                    } else {
                        adapter.append(feedDetails);
                        adapter.notifyDataSetChanged();
                    }
                    bannerImg.setVisibility(View.GONE);
                },
                throwable -> RxUtil.handleError(throwable, BannerFeedsActivity.this)
            );

The type of feedDetails is Object when I use the 0.3.1 version library.

@damianflannery
Copy link

+1. I reverted back to 0.3.0 because of this.

@dlew
Copy link
Contributor

dlew commented Dec 4, 2015

Duplicate of #58, it's been reverted for the next release (whenever that happens, probably soon).

Using 0.3.0 in the meantime fine, since the generics is all that changed.

@dlew dlew closed this as completed Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants