Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LayoutId constructors for AppCompatActivity and (AndroidX)Fragment #308

Merged
merged 2 commits into from
Sep 18, 2019

Conversation

kikuchy
Copy link
Contributor

@kikuchy kikuchy commented Sep 6, 2019

Latest AndroidX AppCompat library supports LayoutId constructor.

https://developer.android.com/jetpack/androidx/releases/appcompat#1.1.0

I want to RxLifecycle's RxAppCompatActivity ,etc... supports that constructor.

@dlew
Copy link
Contributor

dlew commented Sep 12, 2019

I'm a fan of doing this, but this PR only supports a subset of the components for the new constructor. Any particular reason?

@kikuchy
Copy link
Contributor Author

kikuchy commented Sep 17, 2019

I'm a fan of doing this

Isn't it enough reason?
I want to use LayoutId constructor on AppCompatActivity.

If you think it's not enough reason, it ok to close this Pull Request.

@dlew
Copy link
Contributor

dlew commented Sep 17, 2019

I'm asking why the PR is incomplete. It's only using LayoutId for some components, but not for others. We should support them all.

@kikuchy
Copy link
Contributor Author

kikuchy commented Sep 18, 2019

Thank you. Now I'm understanding your opinion.

incomplete

What incomplete?
Only AppCompatActivity/FragmentActivity/(androidx.fragment.app.)Fragment has LayoutId constructor (To be exact, ComponentActivity has LayoutId constructor but RxLifecycle has no direct child class of it), so only RxAppCompatActivity/RxFragmentActivity/(support.)RxFragment have been changed.

@dlew
Copy link
Contributor

dlew commented Sep 18, 2019

Oh weird, I assumed it'd be for all components, not just a handful of them.

@dlew dlew merged commit 1def058 into trello-archive:master Sep 18, 2019
@kikuchy kikuchy deleted the support-constructor branch September 19, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants