Feature/migrate to rxjva 3 #317
Conversation
|
@dlew alternatively we can just remove rxlifecycle-navi module and drop navi support. EDIT: Found this: 69b8a11#diff-04c6e90faac2675aa89e2176d2eec7d8R141 It's time to remove navi ;) |
|
Thanks for the PR - just a warning that I'm very busy right now and probably won't be able to review it for a bit. I'll put it on my queue, just know I'm not ignoring this. |
|
Thank you for your contribution @klamborowski. Before merging this to master, should we create a separate branch for |
gradle.properties
Outdated
| POM_DEVELOPER_NAME=Dan Lew | ||
|
|
||
| android.enableJetifier=true |
There was a problem hiding this comment.
What's causing us to need the Jetifier?
There was a problem hiding this comment.
It's not required, I will remove it in next push.
gradle.properties
Outdated
| @@ -1,5 +1,5 @@ | |||
| GROUP=com.trello.rxlifecycle3 | |||
| VERSION_NAME=3.1.0-SNAPSHOT | |||
| VERSION_NAME=3.3.0-SNAPSHOT | |||
There was a problem hiding this comment.
We should bump to 4.0.0 (since this is a major change).
(Yeah, it's disappointing that it'll be out-of-sync with RxJava3 but... it already was, since RxLifecycle 3.x was compatible with RxJava 2.x!)
| @@ -42,7 +42,6 @@ public void noEvents() { | |||
| stream.onNext("1"); | |||
| stream.onNext("2"); | |||
| testSubscriber.assertValues("1", "2"); | |||
| testSubscriber.assertNotTerminated(); | |||
There was a problem hiding this comment.
assertNotTerminated() was removed, but assertNotComplete() remains. As far as I can tell, that would be the best replacement, since other tests in the same class call assertComplete() - the complete/not complete dichotomy is one worth testing as a result.
(Making this comment here, but assertNotTerminated() has been removed from a bunch of tests.)
klamborowski
force-pushed
the
feature/migrate-to-rxjva-3
branch
from
14312a8 to
c183d22
Compare
Working on migration to rxjva3. Currently WIP and waiting for navi migration: trello-archive/navi#106
Issue #315