Fix some codec issues #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a mistake that Batik 1.8 did not include the ImageIO registry entries, which caused the reader to not be able to handle image tags at all. Once Batik includes them again we can safely remove these.
|
Neat, it works on my computer but not on Travis. Hmm... |
dlew
force-pushed
the
dlew/fix-codec
branch
4 times, most recently
from
ddd495a to
36baf7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two tests provide failing cases for both batik 1.7 or 1.8, depending. The goal is to somehow get both working at once.
Note that this does NOT work yet. I'm just putting this out there in case anyone wants to be ambitious and figure out how to make both these tests pass at once.