Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map save check #1605

Closed
rssk opened this issue Dec 12, 2022 · 0 comments · Fixed by #1684
Closed

Add map save check #1605

rssk opened this issue Dec 12, 2022 · 0 comments · Fixed by #1684
Assignees

Comments

@rssk
Copy link
Contributor

rssk commented Dec 12, 2022

Task Description

On the edit/details mapping page, if not all of the columns are mapped, alert the user that they need to do so

Task Notes

  • generate an alert dialog that tells the user to map all columns, there should already be a component on the page for alert messages
  • if it isnt super hard, highlight in red the columns that still need mapping
  • while youre here test overflow on the mapping columns names, do so by creating a pipeline with long covriate names, i think there are some issues here, and also have a csv you map with similarly long names

Steps to Reproduce

  • create a consortia, pipeline with covariates, then map, observe you dont need to map anything to save
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants