Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast switch double height when sending Ethereum like coin #11309

Open
bosomt opened this issue Feb 22, 2024 · 6 comments
Open

Broadcast switch double height when sending Ethereum like coin #11309

bosomt opened this issue Feb 22, 2024 · 6 comments
Assignees
@izmy
Labels
bug Something isn't working as expected QA NOK Issue doesn't pass the QA and some changes are needed. Ripple XRP
Milestone
Empower - next steps

Comments

@bosomt
Copy link
Contributor

bosomt commented Feb 22, 2024

Describe the bug
Broadcast switch double height when sending Ethereum like coin.

And see how does switch alignment changes when you open/close Coin selection section.
Not sure if worth of design change but reporting...

Steps to reproduce:

  1. Navigate to Send BTC section
  2. Navigate to Send ETH section
  3. Observe Broadcast button

Info:

  • Suite version: web 24.3.0 (a936fd6)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:122.0) Gecko/20100101 Firefox/122.0
  • OS: MacIntel
  • Screen: 1663x1080
  • Device: Trezor T2B1 2.6.5 regular (revision e1f696b4dd8c024a9ceca276d7336b4d93ae7ff2)
  • Transport: BridgeTransport 2.0.33

Screenshots:

Broadcast

ETH
image

BTC
image

Coin control
image
image
@MiroslavProchazka MiroslavProchazka moved this to 🎯 To do in Suite Desktop Feb 24, 2024
@tomasklim
Copy link
Member

Can you recheck? @bosomt

@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Jun 11, 2024
@bosomt
Copy link
Contributor Author

bosomt commented Jun 12, 2024

QA OK

Info:

  • Suite version: desktop 24.6.1 (612073d7f83bcdf3d3c6e28754d5bd6756ca8c1e)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.6.1 Chrome/118.0.5993.159 Electron/27.3.8 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T1B1 1.12.1 regular (revision 1eb0eb9d91b092e571aac63db4ebff2a07fd8a1f)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Jun 12, 2024
@bosomt
Copy link
Contributor Author

bosomt commented Jan 9, 2025

QA NOK

button is still doubled when sending XRP

Image

Info:

  • Suite version: desktop 25.1.1 (4403882efb2a4a802c3d77917d6350a4fae7663d)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/25.1.1 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.7.2 regular (revision da75d8f4b67410b40a9cfd2954d183d81dd6e8e8)
  • Transport: BridgeTransport 3.0.0-bundled.25.1.1

@bosomt bosomt reopened this Jan 9, 2025
@bosomt
Copy link
Contributor Author

bosomt commented Jan 9, 2025

and when on it please fix fees section as well

Image

@tomasklim tomasklim moved this from ✅ Approved to 🎯 To do in Suite Desktop Jan 21, 2025
@tomasklim tomasklim added the Ripple XRP label Jan 21, 2025
@bosomt bosomt added the bug Something isn't working as expected label Jan 27, 2025
@izmy
Copy link
Contributor

izmy commented Jan 28, 2025

Fixed in #16501 and #16513

@izmy izmy closed this as completed Jan 28, 2025
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Jan 28, 2025
@bosomt
Copy link
Contributor Author

bosomt commented Jan 28, 2025

QA NOK

@izmy brodcast button is still double height in send XRP
see https://dev.suite.sldev.cz/suite-web/develop/web/accounts/send#/xrp/0/normal
attached BTC as comparison

Image Image

Info:

  • Suite version: web 25.2.0 (4ee0ed9)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T3T1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🤝 Needs QA to 🎯 To do in Suite Desktop Jan 28, 2025
@bosomt bosomt added the QA NOK Issue doesn't pass the QA and some changes are needed. label Jan 28, 2025
@izmy izmy reopened this Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@izmy izmy

Labels
bug Something isn't working as expected QA NOK Issue doesn't pass the QA and some changes are needed. Ripple XRP
Projects
Suite Desktop
Status: 🎯 To do
Milestone
Empower - next steps
Development

No branches or pull requests
4 participants
@izmy @bosomt @tomasklim @MiroslavProchazka