Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounts tab - network filter should not reset on wallet change #11410

Closed
Hermez-cz opened this issue Mar 2, 2024 · 1 comment · Fixed by #15538
Closed

Accounts tab - network filter should not reset on wallet change #11410

Hermez-cz opened this issue Mar 2, 2024 · 1 comment · Fixed by #15538
Assignees
@tomasklim
Labels
feature Product related issue visible for end user good first issue Issue for newbie developers who want to participate
Milestone
Empower Phase II ...

Comments

@Hermez-cz
Copy link

Hermez-cz commented Mar 2, 2024 •
edited by tomasklim
Loading

Description:
Currently, Suite resets the networks accounts filter on every Wallet switch (even when "switching" back to the aready selected wallet).

Please change the behavior, so the filtered networks stays selected even if the user switches wallets until the instance of the app is running (or ofc until the user deselects it or selects another instead).

You should save it into redux but not into index db

Info:

Suite Version: 24.8.1

How to reproduce
Steps to reproduce the behavior:

Check video or ⬇️

  • remember two different wallets (e.g. standard and 1 hidden passphrase wallet)
  • be on standard wallet and select 1 network in filter
  • switch to second wallet
  • filter resets

Screenshots
Screenshot 2024-09-08 at 9 55 33

Screen.Recording.2024-10-21.at.13.06.33.mov
@MiroslavProchazka MiroslavProchazka moved this to 🎯 To do in Suite Desktop Mar 4, 2024
@komret komret added the good first issue Issue for newbie developers who want to participate label Jul 11, 2024
@tomasklim tomasklim changed the title Filters resetting when changing wallets Accounts tab - network filter should not reset on wallet change Sep 8, 2024
@tomasklim tomasklim added the feature Product related issue visible for end user label Sep 8, 2024
@tomasklim tomasklim self-assigned this Oct 21, 2024
@HelloBanksy HelloBanksy mentioned this issue Nov 1, 2024
Closed
This was referenced Nov 23, 2024
Merged
Merged
@tomasklim tomasklim moved this from 🎯 To do to 🔎 Needs review in Suite Desktop Nov 23, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Suite Desktop Nov 23, 2024
@bosomt
Copy link
Contributor

bosomt commented Nov 26, 2024

QA OK

Info:

  • Suite version: web 24.12.0 (63ca256)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.3 regular (revision 7f373ae71eca855dd41b4a0fdcc7cadaa13a8281)
  • Transport: WebUsbTransport

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasklim tomasklim

Labels
feature Product related issue visible for end user good first issue Issue for newbie developers who want to participate
Projects
Suite Desktop
Archived in project
Milestone
Empower Phase II - Improvements
5 participants
@bosomt @tomasklim @komret @Hermez-cz @MiroslavProchazka