Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passphrase: passphrase entry screen after PIN entry with feature flag disabled #12471

Closed
matejkriz opened this issue May 19, 2024 · 1 comment · Fixed by #12477
Closed

Passphrase: passphrase entry screen after PIN entry with feature flag disabled #12471

matejkriz opened this issue May 19, 2024 · 1 comment · Fixed by #12477
Assignees
@juriczech
Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs

Comments

@matejkriz
Copy link
Member

Describe the bug
Passhprase screen is presented even with passphrase feature flag disabled after PIN entry.

Info:

  • Mobile Suite Version: develop-24.5.0/3e14473a21e65de47dcc6d1c1b3432e5ae5962b0
  • OS: android
  • TT

How to reproduce
(see the video, trezor locked after finished discovery)
Steps to reproduce the behavior:

  1. Wait for finished discovery
  2. Do not enable view only
  3. Do not enable passhprase feature flag
  4. Lock the device (long press on screen for TT)
  5. Exit Suite Lite
  6. Open Suite Lite again
  7. App ask for PIN entry on device
  8. Enter the PIN on device
  9. Passhprase screen is opened

Expected behavior
Discovery of standard wallet should start, no request for passhprase

Screenshots
https://github.com/trezor/trezor-suite/assets/3729633/782c7860-1799-490e-944d-5fd32a5726c2
@matejkriz matejkriz added bug Something isn't working as expected mobile Suite Lite issues and PRs labels May 19, 2024
@matejkriz matejkriz moved this to 🎯 To do in Suite Mobile May 19, 2024
@juriczech juriczech moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile May 20, 2024
@juriczech juriczech self-assigned this May 20, 2024
@juriczech juriczech mentioned this issue May 20, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 👀 Dev done in Suite Mobile May 20, 2024
@juriczech juriczech moved this from 👀 Dev done to 🤝 Needs QA in Suite Mobile May 28, 2024
@STew790
Copy link
Contributor

STew790 commented May 29, 2024

QA OK
Can't reproduce.

24.6.0 29914f2

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juriczech juriczech

Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs
Projects
Suite Mobile
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(suite-native): useEmptyPassphrase on undefined device instance trezor/trezor-suite
3 participants
@matejkriz @juriczech @STew790