Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amount in Send form not reseted after you change token or from/to Eth #13494

Closed
bosomt opened this issue Jul 24, 2024 · 2 comments · Fixed by #16024
Closed

Amount in Send form not reseted after you change token or from/to Eth #13494

bosomt opened this issue Jul 24, 2024 · 2 comments · Fixed by #16024
Assignees
@enjojoy
Labels
bug Something isn't working as expected good first issue Issue for newbie developers who want to participate

Comments

@bosomt
Copy link
Contributor

bosomt commented Jul 24, 2024

Describe the bug
Amount in send form not reseted after you change token or from/to Eth

Steps to reproduce:

  1. Navigate to send form of account that contain Eth and some Erc20 tokens
  2. Click on send max after selecting token or enter amount higher than Eth amount in account
  3. Change to different token with lower amount or to Eth or to token with different decimals
  4. Observe error

Info:

  • Suite version: web 24.8.0 (6cffcc1)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.0 regular (revision dd4671a5104952ef505d28d1f9e94d1484b4607a)
  • Transport: BridgeTransport 2.0.33

Screenshots:
image
image

Screen.Recording.2024-07-24.at.14.17.49.mov
@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Jul 24, 2024
@STew790 STew790 mentioned this issue Sep 17, 2024
Closed
@tomasklim tomasklim added the good first issue Issue for newbie developers who want to participate label Oct 10, 2024
@tomasklim tomasklim added the bug Something isn't working as expected label Nov 24, 2024
@tomasklim
Copy link
Member

Should also reset Send max button

@enjojoy enjojoy self-assigned this Dec 4, 2024
@enjojoy enjojoy mentioned this issue Dec 18, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Issues Suite Dec 18, 2024
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Dec 19, 2024
@bosomt
Copy link
Contributor Author

bosomt commented Dec 19, 2024

QA OK

Info:

  • Suite version: desktop 25.1.0 (7daeb57)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/25.1.0 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3B1 2.8.3 regular (revision 7f373ae71eca855dd41b4a0fdcc7cadaa13a8281)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enjojoy enjojoy

Labels
bug Something isn't working as expected good first issue Issue for newbie developers who want to participate
Projects
Issues Suite
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reset amount, Send max and draft on token change trezor/trezor-suite
3 participants
@bosomt @tomasklim @enjojoy