Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbortButton broken layout #14260

Closed
komret opened this issue Sep 10, 2024 · 4 comments · Fixed by #14287
Closed

AbortButton broken layout #14260

komret opened this issue Sep 10, 2024 · 4 comments · Fixed by #14287
Assignees
@komret
Labels
bug Something isn't working as expected

Comments

@komret
Copy link
Contributor

komret commented Sep 10, 2024

This is the only remaining place AbortButton is used, maybe it can be replaced with a simpler icon?

How to reproduce
Steps to reproduce the behavior:

  • Go to update firmware on TT with FW version < 2.6.0 (or T1 < 1.10.0).
  • Observe broken button

Screenshots
Screenshot 2024-09-10 at 16 43 40
@komret komret added the bug Something isn't working as expected label Sep 10, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Sep 10, 2024
This was referenced Sep 11, 2024
Closed
Merged
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Issues Suite Sep 16, 2024
@bosomt
Copy link
Contributor

bosomt commented Sep 17, 2024

QA NOK

Screen.Recording.2024-09-17.at.11.38.58.mov

Info:

  • Suite version: web 24.10.0 (0cb09ab)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:130.0) Gecko/20100101 Firefox/130.0
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.4.0 regular (revision ea3596ad8)
  • Transport: BridgeTransport 3.0.0-bundled.24.10.0

@bosomt
Copy link
Contributor

bosomt commented Sep 19, 2024

QA NOK

Screenshot 2024-09-19 at 15 16 26

Info:

  • Suite version: desktop 24.10.0 (265028d)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/24.10.0 Chrome/124.0.6367.243 Electron/30.3.1 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T2T1 2.4.0 regular (revision ea3596ad8)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt reopened this Sep 19, 2024
@github-project-automation github-project-automation bot moved this from 🤝 Needs QA to 🎯 To do in Issues Suite Sep 19, 2024
@komret
Copy link
Contributor Author

komret commented Oct 31, 2024

Resolved by #14643.
However, there is another problem: #15157

@komret komret closed this as completed Oct 31, 2024
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Issues Suite Oct 31, 2024
@bosomt
Copy link
Contributor

bosomt commented Nov 1, 2024

QA OK

Image

Info:

  • Suite version: web 24.11.0 (ccc4abd)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 5120x1440
  • Device: Trezor T2T1 2.8.1 regular (revision 632b9561559b7ab6824bb7eeac072874e07b7b82)
  • Transport: WebUsbTransport

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@komret komret

Labels
bug Something isn't working as expected
Projects
Issues Suite
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/reconnect to normal trezor/trezor-suite
2 participants
@bosomt @komret