feat(connect): display descriptive info when firmware cant serve current method #15034
Conversation
|
What about these alternatives: |
|
Regarding the error UX this is what I have for now, which I feel is good enough. 
To implement a direct link to FW install in Suite would have some caveats, such as if we want to open desktop/web Suite, if desktop we need to add a deeplink. |
|
Yes, this is good enough. Thanks! |
martykan
force-pushed
the
connect-wrong-firmware-error
branch
3 times, most recently
from
dcf884d to
de48672
Compare
martykan
changed the title
martykan
force-pushed
the
connect-wrong-firmware-error
branch
from
de48672 to
326e19e
Compare
| if (this.device.firmwareType === 'bitcoin-only') { | ||
| throw ERRORS.TypedError( | ||
| 'Device_MissingCapabilityBtcOnly', | ||
| `Trezor has Bitcoin-only firmware installed, which does not support the ${this.info} method. Please install Universal firmware through Trezor Suite.`, |
There was a problem hiding this comment.
this.info may sometimes yield quite variable results 🤔 just thinking whether it is a good idea to intertwine it together here
There was a problem hiding this comment.
Yeah we could just write "does not support this method" or maybe "does not support this operation", since method may sound strange for less technical people
packages/connect/src/core/index.ts
Outdated
| @@ -428,6 +428,8 @@ const inner = async (context: CoreContext, method: AbstractMethod<any>, device: | |||
| sendCoreMessage(createPopupMessage(POPUP.CANCEL_POPUP_REQUEST)); | |||
| } | |||
|
|
|||
| method.checkDeviceCapability(); | |||
There was a problem hiding this comment.
I am just thinking what is the line to place this check. There are other similar checks, for example this one https://github.com/trezor/trezor-suite/blob/develop/packages/connect/src/core/index.ts#L214
maybe @marekrjpolak has a stronger opinion?
martykan
force-pushed
the
connect-wrong-firmware-error
branch
from
326e19e to
5b6d4c2
Compare
|
maybe put it ahead of permissions check? c4f0ef9 |
|
Sure, looks like it belongs with the earlier checks |
|
/rebase |
trezor-ci
force-pushed
the
connect-wrong-firmware-error
branch
from
c4f0ef9 to
9c1cf66
Compare
very dirty draft, discussion is going on in https://satoshilabs.slack.com/archives/C02V2PSDNA2/p1729692326462089?thread_ts=1729676861.081469&cid=C02V2PSDNA2
resolve #15032