Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): retrieve APK url in github workflow #15949

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

matejkriz
Copy link
Member

@matejkriz matejkriz commented Dec 13, 2024

Description

  • Get APK url in github workflow so it can be uploaded anywhere
  • Delete hook to upload APK on github

Example run: https://github.com/trezor/trezor-suite/actions/runs/12312464741/job/34364557163#step:6:38 (with preview build because of permissions)

Related Issue

Related #5728

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@matejkriz matejkriz requested review from a team and vdovhanych as code owners December 13, 2024 09:59
Copy link

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 20
  • More info

Learn more about 𝝠 Expo Github Action

@matejkriz matejkriz added ci Continuous Integration (CI) related mobile Suite Lite issues and PRs labels Dec 13, 2024
Copy link
Contributor

@vytick vytick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great stuff! 🚀

@vdovhanych
Copy link
Member

lgtm, great stuff! 🚀

This is not done yet :D I will add an app upload to the release site data.trezor.io so it can be downloaded. Or we can do it in a different PR i don't care.

@matejkriz matejkriz merged commit 9048aad into develop Dec 16, 2024
20 of 22 checks passed
@matejkriz matejkriz deleted the chore/native/production-apk branch December 16, 2024 16:25
@matejkriz
Copy link
Member Author

matejkriz commented Dec 16, 2024

This PR so far does nothing, it only removes the option to create a github release for mobile app and prepares the data to be published elswhere...

@matejkriz
Copy link
Member Author

followup here #16008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration (CI) related mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants