Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trade): persistent form state #16332

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix(trade): persistent form state #16332

merged 1 commit into from
Jan 23, 2025

Conversation

adderpositive
Copy link
Contributor

Description

The form in the trading section is updated to be persistent throughout the flow.

Related Issue

Resolve #15092

@adderpositive adderpositive added bug Something isn't working as expected +Invity Related to Invity project labels Jan 13, 2025
@adderpositive adderpositive self-assigned this Jan 13, 2025
TomasBoda
TomasBoda requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@TomasBoda TomasBoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "To" field, I chose BTC, then changed it to ADA and then going back reverts it back to BTC even though there should be ADA.

Screen.Recording.2025-01-20.at.14.57.06.mov

@adderpositive
Copy link
Contributor Author

adderpositive commented Jan 20, 2025 •
edited
Loading

In the "To" field, I chose BTC, then changed it to ADA and then going back reverts it back to BTC even though there should be ADA.
Screen.Recording.2025-01-20.at.14.57.06.mov

Thanks for nice catch :) Fixed f6a23db

@adderpositive adderpositive force-pushed the fix/trade-persistent-form branch 2 times, most recently from b92842d to f6a23db Compare January 20, 2025 17:30
@adderpositive adderpositive mentioned this pull request Jan 21, 2025
Closed
@adderpositive adderpositive force-pushed the fix/trade-persistent-form branch from f6a23db to 21ec151 Compare January 22, 2025 09:17
@tomasklim
Copy link
Member

/rebase

@github-actions GitHub Actions
Copy link

Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12906037270

@trezor-ci trezor-ci force-pushed the fix/trade-persistent-form branch from 21ec151 to 139672d Compare January 22, 2025 10:18
tomasklim
tomasklim approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@tomasklim tomasklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adderpositive adderpositive force-pushed the fix/trade-persistent-form branch 2 times, most recently from 2d60286 to 8ffdf1b Compare January 22, 2025 12:39
@adderpositive adderpositive force-pushed the fix/trade-persistent-form branch from 8ffdf1b to 72949f9 Compare January 23, 2025 07:56
@tomasklim tomasklim merged commit 4839c7b into develop Jan 23, 2025
32 checks passed
@tomasklim tomasklim deleted the fix/trade-persistent-form branch January 23, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izmy izmy izmy approved these changes

@tomasklim tomasklim tomasklim approved these changes

@TomasBoda TomasBoda TomasBoda approved these changes

@LukasRada LukasRada Awaiting requested review from LukasRada

@FreeWall FreeWall Awaiting requested review from FreeWall

Assignees

@adderpositive adderpositive

Labels
bug Something isn't working as expected +Invity Related to Invity project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trading - arrow back clears the state of swap form
4 participants
@adderpositive @tomasklim @izmy @TomasBoda