Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect device communication fixes #16528

Merged
merged 2 commits into from
Jan 22, 2025
Merged

connect device communication fixes #16528

merged 2 commits into from
Jan 22, 2025

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Jan 22, 2025

Before:

  • go to suite (webusb)
  • get address
  • reload
  • observe that the device is stuck

After:

  • sending cancel seems to be the universal remedy, that flushes all the communication and forces the device to cooperate again after exiting the initial communication ungracefully.

Another possible scenario

  • trezorctl get-address --show-display --coin Bitcoin -n "44'/0'/0'/0/0"
  • kill terminal window without approving on device
  • go to suite

possibly related issues:
maybe resolve #4385 (at least the point where app doesn't load after reload)

@mroz22 mroz22 added the no-project This label is used to specify that PR doesn't need to be added to a project label Jan 22, 2025
@mroz22
Copy link
Contributor Author

mroz22 commented Jan 22, 2025

/rebase

Copy link

@mroz22 mroz22 marked this pull request as ready for review January 22, 2025 16:14
@mroz22 mroz22 merged commit 59d6e69 into develop Jan 22, 2025
57 checks passed
@mroz22 mroz22 deleted the device-hang-fix-2 branch January 22, 2025 16:15
@evgenysl
Copy link

Bug is reproducible only with T1B1.

@mroz22
Copy link
Contributor Author

mroz22 commented Jan 23, 2025

Bug is reproducible only with T1B1.

and fixed after this, right?

@evgenysl
Copy link

Yes, on current devel (webUSB), when reloading Trezor Suite, T1 get's reacquired again without any issues.

@evgenysl
Copy link

In both scenarios:

  • get address in Suite (webUSB)
  • trezorctl get-address --show-display --coin Bitcoin -n "44'/0'/0'/0/0"

T1 loads correctly

QA OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-project This label is used to specify that PR doesn't need to be added to a project
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

Change of device settings when discovery is not finished kills my device
3 participants