-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connect device communication fixes #16528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
added
the
no-project
This label is used to specify that PR doesn't need to be added to a project
label
Jan 22, 2025
szymonlesisz
approved these changes
Jan 22, 2025
/rebase |
trezor-ci
force-pushed
the
device-hang-fix-2
branch
from
January 22, 2025 14:47
7757c67
to
5e24a6c
Compare
Bug is reproducible only with T1B1. |
and fixed after this, right? |
Yes, on current devel (webUSB), when reloading Trezor Suite, T1 get's reacquired again without any issues. |
In both scenarios:
T1 loads correctly QA OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Another possible scenario
possibly related issues:
maybe resolve #4385 (at least the point where app doesn't load after reload)