Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETH: catch error from blockbook/geth in estimateFee #3283

Closed
Tracked by #10780
szymonlesisz opened this issue Jan 20, 2021 · 0 comments · Fixed by #11671
Closed
Tracked by #10780

ETH: catch error from blockbook/geth in estimateFee #3283

szymonlesisz opened this issue Jan 20, 2021 · 0 comments · Fixed by #11671
Labels
EVM Issues related to networks based on Ethereum Virtual Machine feature Product related issue visible for end user
Milestone
Suite Trends H1/2024

Comments

@szymonlesisz
Copy link
Contributor

szymonlesisz commented Jan 20, 2021 •
edited by AdamSchinzel
Loading

Describe the bug
handle and parse errors from TrezorConnect.blockchainEstimateFee in ethereum composeTransaction process.
Prevent from sending if invalid smart contract/ other error detected

Currently, a user can pay a fee even for an invalid transaction.

handle errors returned by estimateFee method

@szymonlesisz szymonlesisz added the bug Something isn't working as expected label Jan 20, 2021
@szymonlesisz szymonlesisz self-assigned this Jan 20, 2021
@szymonlesisz szymonlesisz mentioned this issue Jun 16, 2021
Closed
@alex-jerechinsky alex-jerechinsky added MEDIUM feature Product related issue visible for end user and removed bug Something isn't working as expected labels Dec 7, 2021
@hynek-jina hynek-jina removed the MEDIUM label Dec 7, 2021
@matejzak matejzak added the MEDIUM label Jan 4, 2022
@hynek-jina hynek-jina removed the MEDIUM label Jun 8, 2022
@hynek-jina hynek-jina added the altcoins not related to bitcoin label Jul 23, 2022
@tomasklim tomasklim added the EVM Issues related to networks based on Ethereum Virtual Machine label Jan 23, 2024
@tomasklim tomasklim added this to the Suite Trends H1/2024 milestone Jan 23, 2024
@tomasklim tomasklim mentioned this issue Jan 24, 2024
Closed
@tomasklim tomasklim removed the altcoins not related to bitcoin label Jan 24, 2024
@tomasklim tomasklim mentioned this issue Apr 3, 2024
Merged
@github-project-automation github-project-automation bot moved this to 🤝 Needs QA in Suite Desktop May 14, 2024
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
EVM Issues related to networks based on Ethereum Virtual Machine feature Product related issue visible for end user
Projects
Suite Desktop
Archived in project
Milestone
Suite Trends H1/2024
Development

Successfully merging a pull request may close this issue.

fix: handle estimated fee error enjojoy/trezor-suite
5 participants
@szymonlesisz @hynek-jina @matejzak @tomasklim @alex-jerechinsky