Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ripple-lib in blockchain-link #4942

Open
szymonlesisz opened this issue Feb 14, 2022 · 0 comments
Open

update ripple-lib in blockchain-link #4942

szymonlesisz opened this issue Feb 14, 2022 · 0 comments
Labels
code Code improvements connect Connect API related (ie. fee calculation)

Comments

@szymonlesisz
Copy link
Contributor

szymonlesisz commented Feb 14, 2022

ripple-lib is no longer maintained. it's being moved to monorepo and published as xrpl.

Currently we are using patch to pass websocket agent (TOR proxy) to RippleApi websocket constructor.

Now, everything works fine in suite structure but when implemented to trezor-connect (published to npm) this patch isn't there and it shouldnt be there.

We need to:

  1. Replace ripple-lib with xrpl breaking changes expected
  2. Create pull request in xrpl repo and allow passing agent option to Websocket constructor (few lines)
  3. Wait for them to publish new version
  4. Release new blockchain-link

This is kind of blocker for official release of trezor-connect npm package, otherwise ripple backend connections will no longer work for 3rd parties. I've panicked at first :) it's not a blocker, got fix to that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements connect Connect API related (ie. fee calculation)
Projects
Status: No status
Development

No branches or pull requests

2 participants