Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to electron 23 #7172

Closed
karliatto opened this issue Dec 8, 2022 · 2 comments · Fixed by #7626
Closed

Update to electron 23 #7172

karliatto opened this issue Dec 8, 2022 · 2 comments · Fixed by #7626
Assignees
@tomasklim
Labels
code Code improvements

Comments

@karliatto
Copy link
Member

There is a new version of electron and it is now included in nixpkgs so we probably should update.
@karliatto karliatto added the code Code improvements label Dec 8, 2022
@matejkriz matejkriz self-assigned this Jan 12, 2023
@hynek-jina hynek-jina moved this to 🎯 To do in Suite Desktop Jan 16, 2023
@matejkriz matejkriz mentioned this issue Jan 20, 2023
Open
@matejkriz matejkriz removed their assignment Feb 7, 2023
@karliatto karliatto mentioned this issue Feb 13, 2023
Merged
@tomasklim tomasklim mentioned this issue Feb 13, 2023
Merged
@karliatto karliatto changed the title Update to electron 22 Update to electron 23 Feb 14, 2023
@karliatto
Copy link
Member Author

I created new PR for including electron 23 in nix repository NixOS/nixpkgs#216324

Once it is merged we can proceed.

@karliatto
Copy link
Member Author

Latest version 23.1.1 is now available in nixpckgs NixOS/nixpkgs#217868 (comment)

@matejkriz matejkriz moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Desktop Mar 1, 2023
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Desktop Mar 6, 2023
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasklim tomasklim

Labels
code Code improvements
Projects
Suite Desktop
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Electron23 and Node18 trezor/trezor-suite
3 participants
@matejkriz @karliatto @tomasklim