Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and Consolidate AbsorptionSpectrum and SpectrumGenerator classes #141

Open
chummels opened this issue Jun 22, 2020 · 0 comments
Open

Comments

@chummels
Copy link
Collaborator

Right now, SpectrumGenerator, the user-facing class, is a subclass of AbsorptionSpectrum, where most of the actual calculations are done. This is a relic of its development, in that AbsorptionSpectrum was developed in yt prior to the Trident Project, but then we opted to add a lot of features with the development of SpectrumGenerator that weren't pertinent to the full yt userbase.

But now, it just is a bit confusing to have all of this done in two separate classes and I think the code would be simpler to consolidate these two classes into a single class: SpectrumGenerator. This is a longer-term place-marker Issue for a rainy weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant