From 4893b5ca047faecf3b323cccca18becf20ce3086 Mon Sep 17 00:00:00 2001 From: Mateusz Gajewski Date: Wed, 13 Oct 2021 13:04:50 +0200 Subject: [PATCH] Update issue links to correct project location --- .../TestTableScanRedirectionWithPushdown.java | 2 +- .../plugin/hive/TestHiveConnectorTest.java | 18 +++++++++--------- .../product/hive/AbstractTestHiveViews.java | 8 ++++---- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/core/trino-main/src/test/java/io/trino/sql/planner/TestTableScanRedirectionWithPushdown.java b/core/trino-main/src/test/java/io/trino/sql/planner/TestTableScanRedirectionWithPushdown.java index 8108a9cdb4fc..33528d0010b1 100644 --- a/core/trino-main/src/test/java/io/trino/sql/planner/TestTableScanRedirectionWithPushdown.java +++ b/core/trino-main/src/test/java/io/trino/sql/planner/TestTableScanRedirectionWithPushdown.java @@ -263,7 +263,7 @@ public void testPredicateTypeWithCoercion() TupleDomain.all(), Optional.of(ImmutableList.of(DESTINATION_COLUMN_HANDLE_B, DESTINATION_COLUMN_HANDLE_A)))::equals, // PushProjectionIntoTableScan does not preserve enforced constraint - // (issue: https://github.com/prestosql/presto/issues/6029) + // (issue: https://github.com/trinodb/trino/issues/6029) TupleDomain.all(), ImmutableMap.of( "DEST_COL_B", DESTINATION_COLUMN_HANDLE_B::equals, diff --git a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveConnectorTest.java b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveConnectorTest.java index b1b43d096945..d70c725bab27 100644 --- a/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveConnectorTest.java +++ b/plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveConnectorTest.java @@ -7870,18 +7870,18 @@ public void testSelectFromPrestoViewReferencingHiveTableWithTimestamps() assertThat(query(defaultSession, "SELECT ts FROM " + prestoViewNameDefault)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123'"); - // TODO(https://github.com/prestosql/presto/issues/6295) Presto view schema is fixed on creation + // TODO(https://github.com/trinodb/trino/issues/6295) Presto view schema is fixed on creation // should be: assertThat(query(defaultSession, "SELECT ts FROM hive_timestamp_nanos.tpch." + prestoViewNameDefault)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123456789'") assertThat(query(defaultSession, "SELECT ts FROM hive_timestamp_nanos.tpch." + prestoViewNameDefault)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123'"); assertThat(query(millisSession, "SELECT ts FROM " + prestoViewNameDefault)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123'"); assertThat(query(millisSession, "SELECT ts FROM hive_timestamp_nanos.tpch." + prestoViewNameDefault)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123'"); - // TODO(https://github.com/prestosql/presto/issues/6295) Presto view schema is fixed on creation + // TODO(https://github.com/trinodb/trino/issues/6295) Presto view schema is fixed on creation // should be: assertThat(query(nanosSessions, "SELECT ts FROM " + prestoViewNameDefault)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123456789'") assertThat(query(nanosSessions, "SELECT ts FROM " + prestoViewNameDefault)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123'"); - // TODO(https://github.com/prestosql/presto/issues/6295) Presto view schema is fixed on creation + // TODO(https://github.com/trinodb/trino/issues/6295) Presto view schema is fixed on creation // should be: assertThat(query(nanosSessions, "SELECT ts FROM hive_timestamp_nanos.tpch." + prestoViewNameDefault)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123456789'") assertThat(query(nanosSessions, "SELECT ts FROM hive_timestamp_nanos.tpch." + prestoViewNameDefault)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123'"); @@ -7889,27 +7889,27 @@ public void testSelectFromPrestoViewReferencingHiveTableWithTimestamps() String prestoViewNameNanos = "presto_view_ts_nanos_" + randomTableSuffix(); assertUpdate(nanosSessions, "CREATE VIEW " + prestoViewNameNanos + " AS SELECT * FROM " + tableName); - // TODO(https://github.com/prestosql/presto/issues/6295) Presto view schema is fixed on creation + // TODO(https://github.com/trinodb/trino/issues/6295) Presto view schema is fixed on creation // should be: assertThat(query(defaultSession, "SELECT ts FROM " + prestoViewNameNanos)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123'") assertThat(query(defaultSession, "SELECT ts FROM " + prestoViewNameNanos)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123000000'"); - // TODO(https://github.com/prestosql/presto/issues/6295) Presto view schema is fixed on creation + // TODO(https://github.com/trinodb/trino/issues/6295) Presto view schema is fixed on creation // should be: assertThat(query(defaultSession, "SELECT ts FROM hive_timestamp_nanos.tpch." + prestoViewNameNanos)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123456789'") assertThat(query(defaultSession, "SELECT ts FROM hive_timestamp_nanos.tpch." + prestoViewNameNanos)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123000000'"); - // TODO(https://github.com/prestosql/presto/issues/6295) Presto view schema is fixed on creation + // TODO(https://github.com/trinodb/trino/issues/6295) Presto view schema is fixed on creation // should be: assertThat(query(millisSession, "SELECT ts FROM " + prestoViewNameNanos)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123'") assertThat(query(millisSession, "SELECT ts FROM " + prestoViewNameNanos)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123000000'"); - // TODO(https://github.com/prestosql/presto/issues/6295) Presto view schema is fixed on creation + // TODO(https://github.com/trinodb/trino/issues/6295) Presto view schema is fixed on creation // should be: assertThat(query(millisSession, "SELECT ts FROM hive_timestamp_nanos.tpch." + prestoViewNameNanos)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123'") assertThat(query(millisSession, "SELECT ts FROM hive_timestamp_nanos.tpch." + prestoViewNameNanos)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123000000'"); - // TODO(https://github.com/prestosql/presto/issues/6295) Presto view schema is fixed on creation + // TODO(https://github.com/trinodb/trino/issues/6295) Presto view schema is fixed on creation // should be: assertThat(query(nanosSessions, "SELECT ts FROM " + prestoViewNameNanos)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123456789'") assertThat(query(nanosSessions, "SELECT ts FROM " + prestoViewNameNanos)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123000000'"); - // TODO(https://github.com/prestosql/presto/issues/6295) Presto view schema is fixed on creation + // TODO(https://github.com/trinodb/trino/issues/6295) Presto view schema is fixed on creation // should be: assertThat(query(nanosSessions, "SELECT ts FROM hive_timestamp_nanos.tpch." + prestoViewNameNanos)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123456789'") assertThat(query(nanosSessions, "SELECT ts FROM hive_timestamp_nanos.tpch." + prestoViewNameNanos)).matches("VALUES TIMESTAMP '1990-01-02 12:13:14.123000000'"); } diff --git a/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/AbstractTestHiveViews.java b/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/AbstractTestHiveViews.java index 109c23d79331..dd00940147fa 100644 --- a/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/AbstractTestHiveViews.java +++ b/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/AbstractTestHiveViews.java @@ -406,7 +406,7 @@ public void testTimestampHiveView() assertThat(query("SELECT CAST(ts AS varchar) FROM timestamp_hive_view")).containsOnly(row("1990-01-02 12:13:14.123")); assertThatThrownBy( - // TODO(https://github.com/prestosql/presto/issues/6295) it is not possible to query Hive view with timestamps if hive.timestamp-precision=NANOSECONDS + // TODO(https://github.com/trinodb/trino/issues/6295) it is not possible to query Hive view with timestamps if hive.timestamp-precision=NANOSECONDS () -> assertThat(query("SELECT CAST(ts AS varchar) FROM hive_timestamp_nanos.default.timestamp_hive_view")).containsOnly(row("1990-01-02 12:13:14.123456789")) ).hasMessageContaining("timestamp(9) projected from query view at position 0 cannot be coerced to column [ts] of type timestamp(3) stored in view definition"); @@ -415,18 +415,18 @@ public void testTimestampHiveView() assertThat(query("SELECT CAST(ts AS varchar) FROM timestamp_hive_view")).containsOnly(row("1990-01-02 12:13:14.123")); assertThatThrownBy( - // TODO(https://github.com/prestosql/presto/issues/6295) it is not possible to query Hive view with timestamps if hive.timestamp-precision=NANOSECONDS + // TODO(https://github.com/trinodb/trino/issues/6295) it is not possible to query Hive view with timestamps if hive.timestamp-precision=NANOSECONDS () -> assertThat(query("SELECT CAST(ts AS varchar) FROM hive_timestamp_nanos.default.timestamp_hive_view")).containsOnly(row("1990-01-02 12:13:14.123")) ).hasMessageContaining("timestamp(9) projected from query view at position 0 cannot be coerced to column [ts] of type timestamp(3) stored in view definition"); setSessionProperty("hive.timestamp_precision", "'NANOSECONDS'"); setSessionProperty("hive_timestamp_nanos.timestamp_precision", "'NANOSECONDS'"); - // TODO(https://github.com/prestosql/presto/issues/6295) timestamp_precision has no effect on Hive views + // TODO(https://github.com/trinodb/trino/issues/6295) timestamp_precision has no effect on Hive views // should be: assertThat(query("SELECT CAST(ts AS varchar) FROM timestamp_hive_view")).containsOnly(row("1990-01-02 12:13:14.123456789")) assertThat(query("SELECT CAST(ts AS varchar) FROM timestamp_hive_view")).containsOnly(row("1990-01-02 12:13:14.123")); assertThatThrownBy( - // TODO(https://github.com/prestosql/presto/issues/6295) it is not possible to query Hive view with timestamps if hive.timestamp-precision=NANOSECONDS + // TODO(https://github.com/trinodb/trino/issues/6295) it is not possible to query Hive view with timestamps if hive.timestamp-precision=NANOSECONDS () -> assertThat(query("SELECT CAST(ts AS varchar) FROM hive_timestamp_nanos.default.timestamp_hive_view")).containsOnly(row("1990-01-02 12:13:14.123456789")) ).hasMessageContaining("timestamp(9) projected from query view at position 0 cannot be coerced to column [ts] of type timestamp(3) stored in view definition"); }