From 695a222ceecfe535c7c6465e2ce613105be59955 Mon Sep 17 00:00:00 2001 From: Karol Sobczak Date: Wed, 12 Jan 2022 15:22:56 +0100 Subject: [PATCH] Increase OrcReader#MAX_BATCH_SIZE to 8196 --- lib/trino-orc/src/main/java/io/trino/orc/OrcReader.java | 2 +- .../src/test/java/io/trino/orc/TestReadBloomFilter.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/trino-orc/src/main/java/io/trino/orc/OrcReader.java b/lib/trino-orc/src/main/java/io/trino/orc/OrcReader.java index fe0373a7186c..878022f9fe7c 100644 --- a/lib/trino-orc/src/main/java/io/trino/orc/OrcReader.java +++ b/lib/trino-orc/src/main/java/io/trino/orc/OrcReader.java @@ -65,7 +65,7 @@ public class OrcReader { - public static final int MAX_BATCH_SIZE = 1024; + public static final int MAX_BATCH_SIZE = 8196; public static final int INITIAL_BATCH_SIZE = 1; public static final int BATCH_SIZE_GROWTH_FACTOR = 2; diff --git a/lib/trino-orc/src/test/java/io/trino/orc/TestReadBloomFilter.java b/lib/trino-orc/src/test/java/io/trino/orc/TestReadBloomFilter.java index 18f2fe8c1493..8340a3c58bd9 100644 --- a/lib/trino-orc/src/test/java/io/trino/orc/TestReadBloomFilter.java +++ b/lib/trino-orc/src/test/java/io/trino/orc/TestReadBloomFilter.java @@ -89,7 +89,7 @@ private static void testType(Type type, List uniqueValues, T inBloomFilte // without predicate a normal block will be created try (OrcRecordReader recordReader = createCustomOrcRecordReader(tempFile, OrcPredicate.TRUE, type, MAX_BATCH_SIZE)) { - assertEquals(recordReader.nextPage().getLoadedPage().getPositionCount(), 1024); + assertEquals(recordReader.nextPage().getLoadedPage().getPositionCount(), 8196); } // predicate for specific value within the min/max range without bloom filter being enabled @@ -98,7 +98,7 @@ private static void testType(Type type, List uniqueValues, T inBloomFilte .build(); try (OrcRecordReader recordReader = createCustomOrcRecordReader(tempFile, noBloomFilterPredicate, type, MAX_BATCH_SIZE)) { - assertEquals(recordReader.nextPage().getLoadedPage().getPositionCount(), 1024); + assertEquals(recordReader.nextPage().getLoadedPage().getPositionCount(), 8196); } // predicate for specific value within the min/max range with bloom filter enabled, but a value not in the bloom filter @@ -118,7 +118,7 @@ private static void testType(Type type, List uniqueValues, T inBloomFilte .build(); try (OrcRecordReader recordReader = createCustomOrcRecordReader(tempFile, matchBloomFilterPredicate, type, MAX_BATCH_SIZE)) { - assertEquals(recordReader.nextPage().getLoadedPage().getPositionCount(), 1024); + assertEquals(recordReader.nextPage().getLoadedPage().getPositionCount(), 8196); } } }