Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Phoenix tests failing on JDK 17 #10010

Closed
wendigo opened this issue Nov 19, 2021 · 21 comments
Closed

Fix Phoenix tests failing on JDK 17 #10010

wendigo opened this issue Nov 19, 2021 · 21 comments

Comments

@wendigo
Copy link
Contributor

wendigo commented Nov 19, 2021 •
edited
Loading

Some of the Phoenix 4 and 5 tests are failing on JDK 17
@wendigo wendigo mentioned this issue Nov 19, 2021
Closed
8 tasks
@lhofhansl
Copy link
Member

@vincentpoon FYI.

@wendigo
Copy link
Contributor Author

wendigo commented Nov 23, 2021

@vincentpoon if there is other solution - please let me know. I'm interested in fixing those tests, as they are the only one failing on JDK 17 right now.

@vincentpoon
Copy link
Member

@wendigo Do you know what the problem is when starting the Testing HBase? Do you have steps I can use to repro?

The other stacktrace you pasted is just a Warning - that is something intrinsic to HBase, which is still on older versions of the JDK, so not something we can change easily externally, but may be ignorable.

@wendigo
Copy link
Contributor Author

wendigo commented Nov 23, 2021

@vincentpoon just switch project JDK to 17 in IntelliJ and try to run any Phoenix test.

@vincentpoon
Copy link
Member

@wendigo The tests run fine for me with JDK 17. There are some test failures, but might be unrelated. But at least the TestingPhoenixServer appears to work. I ran TestPhoenixConnectorTest

@wendigo
Copy link
Contributor Author

wendigo commented Nov 24, 2021

@vincentpoon you can see failures here: #10004

@wendigo
Copy link
Contributor Author

wendigo commented Nov 24, 2021 

Error:  io.trino.plugin.phoenix5.TestPhoenixConnectorTest.init  Time elapsed: 20.265 s  <<< FAILURE!
java.lang.RuntimeException: Can't start phoenix server.
	at io.trino.plugin.phoenix5.TestingPhoenixServer.<init>(TestingPhoenixServer.java:106)
	at io.trino.plugin.phoenix5.TestingPhoenixServer.getInstance(TestingPhoenixServer.java:50)
	at io.trino.plugin.phoenix5.TestPhoenixConnectorTest.createQueryRunner(TestPhoenixConnectorTest.java:72)
	at io.trino.testing.AbstractTestQueryFramework.init(AbstractTestQueryFramework.java:99)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.Invoker.invokeConfigurationMethod(Invoker.java:515)
	at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:217)
	at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:144)
	at org.testng.internal.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:169)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.io.IOException: Shutting down
	at org.apache.hadoop.hbase.MiniHBaseCluster.init(MiniHBaseCluster.java:266)
	at org.apache.hadoop.hbase.MiniHBaseCluster.<init>(MiniHBaseCluster.java:116)
	at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniHBaseCluster(HBaseTestingUtility.java:1169)
	at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniHBaseCluster(HBaseTestingUtility.java:1213)
	at io.trino.plugin.phoenix5.TestingPhoenixServer.<init>(TestingPhoenixServer.java:101)
	... 16 more
Caused by: java.lang.RuntimeException: Failed construction of Master: class org.apache.hadoop.hbase.master.HMasterKeeperErrorCode = ConnectionLoss for /hbase
	at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:137)
	at org.apache.hadoop.hbase.LocalHBaseCluster.addMaster(LocalHBaseCluster.java:227)
	at org.apache.hadoop.hbase.LocalHBaseCluster.<init>(LocalHBaseCluster.java:174)
	at org.apache.hadoop.hbase.MiniHBaseCluster.init(MiniHBaseCluster.java:245)
	... 20 more
Caused by: org.apache.hadoop.hbase.ZooKeeperConnectionException: master:376530x0, quorum=localhost:62689, baseZNode=/hbase Unexpected KeeperException creating base node
	at org.apache.hadoop.hbase.zookeeper.ZKWatcher.createBaseZNodes(ZKWatcher.java:210)
	at org.apache.hadoop.hbase.zookeeper.ZKWatcher.<init>(ZKWatcher.java:183)
	at org.apache.hadoop.hbase.zookeeper.ZKWatcher.<init>(ZKWatcher.java:135)
	at org.apache.hadoop.hbase.regionserver.HRegionServer.<init>(HRegionServer.java:652)
	at org.apache.hadoop.hbase.master.HMaster.<init>(HMaster.java:493)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
	at org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:132)
	... 23 more
Caused by: org.apache.phoenix.shaded.org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase
	at org.apache.phoenix.shaded.org.apache.zookeeper.KeeperException.create(KeeperException.java:102)
	at org.apache.phoenix.shaded.org.apache.zookeeper.KeeperException.create(KeeperException.java:54)
	at org.apache.phoenix.shaded.org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:792)
	at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.createNonSequential(RecoverableZooKeeper.java:547)
	at org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.create(RecoverableZooKeeper.java:526)
	at org.apache.hadoop.hbase.zookeeper.ZKUtil.createWithParents(ZKUtil.java:1197)
	at org.apache.hadoop.hbase.zookeeper.ZKUtil.createWithParents(ZKUtil.java:1175)
	at org.apache.hadoop.hbase.zookeeper.ZKWatcher.createBaseZNodes(ZKWatcher.java:201)
	... 33 more

@wendigo wendigo changed the title Migrate to testing/phoenix{4,5} docker images in Phoenix tests Fix Phoenix tests failing on JDK 17 Nov 24, 2021
@wendigo
Copy link
Contributor Author

wendigo commented Nov 24, 2021

There is also a failure in product test:

2021-11-23T13:15:49.6263039Z presto-master       | 2021-11-23T19:00:49.625+0545	WARN	ReadOnlyZKClient-phoenix:2181@0x79ce1b3b-SendThread(phoenix:2181)	org.apache.phoenix.shaded.org.apache.zookeeper.ClientCnxn	Session 0x0 for server phoenix/<unresolved>:2181, unexpected error, closing socket connection and attempting reconnect
2021-11-23T13:15:49.6266762Z presto-master       | java.lang.IllegalArgumentException: Unable to canonicalize address phoenix/<unresolved>:2181 because it's not resolvable
2021-11-23T13:15:49.6270221Z presto-master       | 	at org.apache.phoenix.shaded.org.apache.zookeeper.SaslServerPrincipal.getServerPrincipal(SaslServerPrincipal.java:65)
2021-11-23T13:15:49.6274969Z presto-master       | 	at org.apache.phoenix.shaded.org.apache.zookeeper.SaslServerPrincipal.getServerPrincipal(SaslServerPrincipal.java:41)
2021-11-23T13:15:49.6280753Z presto-master       | 	at org.apache.phoenix.shaded.org.apache.zookeeper.ClientCnxn$SendThread.startConnect(ClientCnxn.java:1001)
2021-11-23T13:15:49.6284663Z presto-master       | 	at org.apache.phoenix.shaded.org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1060)

@wendigo
Copy link
Contributor Author

wendigo commented Nov 24, 2021

@vincentpoon you are right. I guess that I've messed with my environment too much. There are still some weird failures in tests. Can you take a look?

@wendigo
Copy link
Contributor Author

wendigo commented Nov 24, 2021

Product tests are failing only for phoenix5

@martint
Copy link
Member

martint commented Dec 14, 2021

Any updates on this?

@wendigo
Copy link
Contributor Author

wendigo commented Dec 14, 2021

@martint I'm planning to spend some time on JDK 17 between christmas and new year's eve.

@wendigo
Copy link
Contributor Author

wendigo commented Dec 15, 2021

This is related to https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8225499. More reference: quarkusio/quarkus#8212

@wendigo
Copy link
Contributor Author

wendigo commented Dec 15, 2021

https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8232369

@wendigo
Copy link
Contributor Author

wendigo commented May 6, 2022

@vincentpoon I've filled apache/phoenix#1434

@findepi
Copy link
Member

findepi commented Jan 26, 2023

@wendigo can this be closed?

@wendigo
Copy link
Contributor Author

wendigo commented Jan 26, 2023

@findepi No

@findepi
Copy link
Member

findepi commented Jan 26, 2023

Then please explain what's to be done here. "Phoenix tests failing on JDK 17" implies that CI would be red if we were running on Java 17. We are running on Java 17. What am i missing?

@vincentpoon
Copy link
Member

The Phoenix patch above was merged, so is this just a matter of updating to that Phoenix version?

@wendigo
Copy link
Contributor Author

wendigo commented Jan 27, 2023

@vincentpoon I've tried that but zookeeper is still failing on 17 :(

@ebyhr
Copy link
Member

ebyhr commented Jan 30, 2025

Is this issue still effective?

@wendigo wendigo closed this as completed Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@martint @wendigo @findepi @lhofhansl @vincentpoon @ebyhr