From 16ce143b54eacf465c5a90a6aabdc9c3a723cb99 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Fri, 22 Nov 2024 11:16:23 -0800 Subject: [PATCH] [AMD] Re-enable overflow test in test_reduce_layouts (#5233) https://github.com/triton-lang/triton/pull/5153 fixed the issue; but we missed enabling one of the disabled case. --- python/test/unit/language/test_core.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/python/test/unit/language/test_core.py b/python/test/unit/language/test_core.py index e62373d6fb25..b2e0fa59a8d4 100644 --- a/python/test/unit/language/test_core.py +++ b/python/test/unit/language/test_core.py @@ -2666,8 +2666,6 @@ def test_reduce_layouts(M, N, src_layout, axis, epilogue_kind, dtype_str, add_ov pytest.skip("Skipping because tensor shape is smaller than M(f)maLayout instr_shape") if is_hip() and isinstance(src_layout, MfmaLayout) and ((M, N) == (128, 128)): pytest.skip("Skipping test because it runs out of shared memory") - if add_overflow_check is True and is_hip(): - pytest.skip("overflow check disabled on HIP while fixing issues") if reduce_op == "sum" and dtype_str == "float16" and M * N > 1024: pytest.skip("Skipping sum reduction on float16 due to accuracy issues")