logthreads and logqthreads seem to behave similarly

[biona001]

Hello, I tested a for loop with the logthreads and logqthreads macro, but the resulting plot seem to behave quite similarly:

logthreads:

logqthreads:

I expected each thread in logqthreads to be roughly the same length. Did I misunderstand something or is this a bug? There figures are produced at the end of this notebook. Sorry I didn't provide a MWE since this is quite complicated to generate.

[tro3]

You are absolutely correct! A couple logged version macro invocations got swapped - logqthreads is one. I will fix now and issue a new revision.

In the meantime, you can generate the correct macro with:

import ThreadPools: _pthread_macro, LoggedQueuePool, pwith, tforeach

macro logqthreads_fixed(args...)
  return _pthread_macro(LoggedQueuePool(1), true, args...)
end

pool = @logqthreads_fixed for w in 1:windows
  ...

[tro3]

Now updated and released:

 pkg> update ThreadPools
...
 [b189fb0b] ↑ ThreadPools v1.1.0 ⇒ v1.1.1

Let me know if you have any trouble, and thanks for the feedback.