Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(smokeping): Allow priviledge escalation #1769

Merged
merged 2 commits into from
Jan 23, 2022
Merged

fix(smokeping): Allow priviledge escalation #1769

merged 2 commits into from
Jan 23, 2022

Conversation

stavros-k
Copy link
Collaborator

Description

Fixes #1767

Type of change

  • Feature/App addition
  • Bugfix
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor of current code

How Has This Been Tested?

Notes:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests to this description that prove my fix is effective or that my feature works
  • I increased versions for any altered app according to semantic versioning

@stavros-k stavros-k self-assigned this Jan 23, 2022
@PrivatePuffin
Copy link
Member

please resolve conflicts... (aka: rebase)

@PrivatePuffin PrivatePuffin merged commit 33cc9ee into truecharts:master Jan 23, 2022
@stavros-k stavros-k deleted the smokeping branch January 23, 2022 22:21
@truecharts-admin
Copy link
Collaborator

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

@truecharts truecharts locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PrivatePuffin PrivatePuffin Awaiting requested review from PrivatePuffin PrivatePuffin is a code owner

Assignees

@stavros-k stavros-k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SMOKEPING] fping does not work with default options
3 participants
@stavros-k @PrivatePuffin @truecharts-admin