Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix bug where ganache treats all transactions as having a chainId of 1, but RPC eth_chainId returns 1337 (we need to just make chainId configurable). We need investigate aligning net_version and chain_id as metamask uses net_version instead of chain_id for signing transactions. #557

Closed
davidmurdoch opened this issue Apr 8, 2020 · 1 comment
Closed

fix bug where ganache treats all transactions as having a chainId of 1, but RPC eth_chainId returns 1337 (we need to just make chainId configurable). We need investigate aligning net_version and chain_id as metamask uses net_version instead of chain_id for signing transactions. #557

davidmurdoch opened this issue Apr 8, 2020 · 1 comment
Milestone
7.0.0

Comments

@davidmurdoch
Copy link
Member

fix bug where ganache treats all transactions as having a chainId of 1, but RPC eth_chainId returns 1337 (we need to just make chainId configurable). We need investigate aligning net_version and chain_id as metamask uses net_version instead of chain_id for signing transactions.
@davidmurdoch davidmurdoch added this to the 3.0.0 milestone Apr 8, 2020
@davidmurdoch davidmurdoch mentioned this issue Jun 12, 2020
Closed
@davidmurdoch davidmurdoch mentioned this issue Sep 11, 2020
Closed
@davidmurdoch
Copy link
Member Author

Closing, as this is fixed in the upcoming v3 release, and is now configurable via options in v2. Current plan is not to align net_version and chainId, as they hold different meanings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
1 participant
@davidmurdoch