Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Upgrade solc to v0.4.17 #604

Closed
2 of 3 tasks
gnidan opened this issue Oct 5, 2017 · 2 comments
Closed
2 of 3 tasks

Upgrade solc to v0.4.17 #604

gnidan opened this issue Oct 5, 2017 · 2 comments

Comments

@gnidan
Copy link
Contributor

gnidan commented Oct 5, 2017

  • Version bumps
  • Warnings for internal Solidity code
  • Update Truffle Boxes to remove warnings (this will have to go out after the full Truffle 4 release)
@gnidan
Copy link
Contributor Author

gnidan commented Oct 6, 2017

Heads up about this, @DiscRiskandBisque @bmmpxf:

Solidity v0.4.17 adds keywords pure and view to replace constant, and now throws warnings if you don't explicitly indicate the visibility modifier for a function (external/internal/private/public)

The Truffle Boxes are all likely to cause two kinds of warnings with this solc version:

  1. The compiler will warn to suggest view/pure in place of constant
  2. The compiler will warn for visibility modifiers being missing.

Fixing the first issue will break compatibility, as older versions of Solidity don't know about pure and view. This will necessarily have to wait until the full Truffle 4 release.

The second issue can be addressed at any time, although I would say it is perhaps not likely a blocker for release.

@gnidan
Copy link
Contributor Author

gnidan commented Oct 19, 2017

Closing because 0.4.18 is out. Moving to #628

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant