Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] TimePicker/Combobox filtering #1108

Closed
brandonlenz opened this issue Apr 9, 2021 · 0 comments · Fixed by #1139
Closed

[fix] TimePicker/Combobox filtering #1108

brandonlenz opened this issue Apr 9, 2021 · 0 comments · Fixed by #1139
Assignees
Labels
type: bug Something isn't working like it's supposed to

Comments

@brandonlenz
Copy link
Contributor

ReactUSWDS Version & USWDS Version:

2.9.0

Describe the bug

Filtering works differently for the TimePicker (possibly due to combobox filtering changes from 2.8.1 to 2.9.0)

The current TimePicker excludes options when there is no matching item (it filters very strictly). The USWDS TimePicker does not filter out (by hiding) items that do not match. Instead it focuses the first item that does match, if any.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the ReactUSWDS implementation in storybook and filter using a letter
  2. Go to the USWDS implementation and filter using the same input and notice a difference in options

Expected behavior

The filtering behavior should be identical to the USWDS implementation

Screenshots

ReactUSWDS implementation:
image

USWDS Implementation:
image

Additional context

@brandonlenz brandonlenz added the type: bug Something isn't working like it's supposed to label Apr 9, 2021
@brandonlenz brandonlenz self-assigned this Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working like it's supposed to
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant