feat: implement ProcessListHeading subcomponent #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…List and ProcessListItem components, rendering some text in a div in Storybook
…ility to pass in attributes
…orks/react-uswds into ak-new-component-process-list-979
…ng in default storybook example
SirenaBorracha
requested review from
ahobson,
brandonlenz,
gidjin,
haworku,
sarboc,
suzubara and
tinyels
as code owners
…ations, export ProcessListHeading from index.ts
|
Oh, do you want this branch targeting main? edit: all clear, I forgot the process list PR is open, This should be merged after process list. |
brandonlenz
added
the
status: hold merge
brandonlenz
reviewed
Apr 27, 2021
…orks/react-uswds into ak-process-list-subcomponent-1134
brandonlenz
approved these changes
Apr 27, 2021
Merged
SirenaBorracha
added a commit
that referenced
this pull request
May 5, 2021
## [1.17.0](1.16.0...1.17.0) (2021-05-05) ### Features * Checkbox Tile Variant ([#1104](#1104)) ([9936c4a](9936c4a)) * Implement ProcessListHeading subcomponent ([#1162](#1162)) ([964e34c](964e34c)) * New Component ProcessList MVP ([#1107](#1107)) ([1bc0f93](1bc0f93)) * New Component SiteAlert ([#1099](#1099)) ([c1e88e0](c1e88e0)) * New Component SummaryBox ([#1098](#1098)) ([b2279b4](b2279b4)) * Radio Button Tile Variant ([#1101](#1101)) ([a2f40a0](a2f40a0)) * Update Grid components to render any type of element ([#1166](#1166)) ([07468c8](07468c8)), closes [#1194](#1194) * Update Search component to support i18n ([#1192](#1192)) ([5241d15](5241d15)) * Update Table to 2.10.0 implementation ([#1110](#1110)) ([117a6c7](117a6c7))
brandonlenz
pushed a commit
that referenced
this pull request
May 12, 2021
* Create subfolders and files, write and pass one test each for ProcessList and ProcessListItem components, rendering some text in a div in Storybook * Import ProcessListItem to the stories file and render some text in a div on Storybook * Add minimum Storybook examples as skeletons, create props interfaces, update tests * Disable anchor is valid check in test files, add test checking for ability to pass in attributes * Export ProcessList components from index.ts * Remove unnecessary fragment * Add ProcessListHeading to ProcessList test data, use ProcessListHeading in default storybook example * Use ProcessListHeading custom component in storybook * Remove unnecessary childwithprops from CustomHeadingProps type declarations, export ProcessListHeading from index.ts * Accidentally left off an & T * Make changes to ProcessListHeading based on PR feedback, update tests and syntax * Remove whitespace from package.json * Remove weird whitespace addition to yarn.lock * Regenerate yarn.lock * Merge changes from ProcessList * Regenerate yarn.lock * Replace mistakenly deleted period from stories file
brandonlenz
pushed a commit
that referenced
this pull request
May 12, 2021
## [1.17.0](1.16.0...1.17.0) (2021-05-05) ### Features * Checkbox Tile Variant ([#1104](#1104)) ([9936c4a](9936c4a)) * Implement ProcessListHeading subcomponent ([#1162](#1162)) ([964e34c](964e34c)) * New Component ProcessList MVP ([#1107](#1107)) ([1bc0f93](1bc0f93)) * New Component SiteAlert ([#1099](#1099)) ([c1e88e0](c1e88e0)) * New Component SummaryBox ([#1098](#1098)) ([b2279b4](b2279b4)) * Radio Button Tile Variant ([#1101](#1101)) ([a2f40a0](a2f40a0)) * Update Grid components to render any type of element ([#1166](#1166)) ([07468c8](07468c8)), closes [#1194](#1194) * Update Search component to support i18n ([#1192](#1192)) ([5241d15](5241d15)) * Update Table to 2.10.0 implementation ([#1110](#1110)) ([117a6c7](117a6c7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the
ProcessListHeadingsubcomponent so that users have an out of the box heading component and do not have to manually apply the USWDS heading className.Related Issues or PRs
closes #1134
As the MVP ProcessList PR #1107 has not yet been merged, I made that branch the target for this PR.
How To Test
Check out this branch and run
yarn testto execute tests andyarn storybookto see the component in action.Alternatively, you can scroll to the bottom of this page and click "Show environments" on the right above the comment input box to access this component in Storybook.
Screenshots (optional)
Nothing is changed visually in this PR from the MVP ProcessList component PR #1107