feat: Update banner aria props with changes from USWDS #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonlenz
requested review from
gidjin,
haworku,
ahobson and
SirenaBorracha
as code owners
brandonlenz
changed the title
werdnanoslen
approved these changes
May 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2185
Related Issues or PRs
In response to uswds/uswds#4925 and uswds/uswds#4912, USWDS updated some aria attributes in https://github.com/uswds/uswds/pull/4925/files
How To Test
All CI checks pass
Verify aria attributes match USWDS source code