fix: a11y: adds css to hide search clear button that causes accessibility issues #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shkeating
added
type: bug
shkeating
requested review from
haworku,
ahobson,
brandonlenz and
SirenaBorracha
as code owners
brandonlenz
approved these changes
Jun 28, 2023
|
Since the SCSS implementation of this library is always hard (to me) I'll be curious to know if you have to do anything special to make sure to use react-uswds' index.scss when setting up react uswds + uswds on consuming projects |
gidjin
pushed a commit
that referenced
this pull request
Jul 14, 2023
## [5.1.0](5.0.0...5.1.0) (2023-07-14) ### Features * added customizable text control to file input ([#2417](#2417)) ([0a387be](0a387be)) * adds unbounded functionality to pagination ([#2418](#2418)) ([f9e7957](f9e7957)) ### Bug Fixes * a11y: adds css to hide search clear button that causes accessibility issues ([#2467](#2467)) ([d19527f](d19527f)) * added error param, test, story ([#2488](#2488)) ([42da85d](42da85d)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues or PRs
USWDS issue: uswds/uswds#5277
Chromium issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1147314
How To Test
yarn storybookhttp://localhost:9009/?path=/story/components-search-search--default-search
Screenshots (optional)
before:
after:
