Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding new components docs, rework development docs #73 #248

Merged
merged 5 commits into from
Jun 12, 2020

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Jun 8, 2020

Summary

  • New docs live in new file - adding_new_components.md. Other titles welcome. Sections include Checklist, Navigating Documentation, Guiding Patterns, and Common Components
  • Reorganized "Development" docs slightly (added Pull Requests section to highlight that info).
  • Add table of contents to contributing.md

Related Issues or PRs

closes #73

Feedback requested

  • Feel free to make commits or suggestions directly with edits.

@haworku haworku requested a review from eamahanna June 10, 2020 13:41
Copy link
Contributor

@eamahanna eamahanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you

Copy link
Contributor

@suzubara suzubara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for writing this up!

@haworku haworku merged commit 981956f into develop Jun 12, 2020
@haworku haworku deleted the hw-new-component-docs branch June 12, 2020 13:25
@haworku haworku mentioned this pull request Jun 29, 2020
haworku added a commit that referenced this pull request Jun 29, 2020
* docs: reword developing, contributing md, add to codeowners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more documentation around how to contribute and write new components
3 participants