Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated storybook templates #2522

Merged
merged 4 commits into from
Jul 26, 2023
Merged

docs: Updated storybook templates #2522

merged 4 commits into from
Jul 26, 2023

Conversation

werdnanoslen
Copy link
Contributor

Summary

Updates address and name storybook templates

Related Issues or PRs

Resolves #2519

How To Test

Open address and name and compare to USWDS templates

Screenshots (optional)

image image

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.

Generated by 🚫 dangerJS against b17a4cf

@werdnanoslen
Copy link
Contributor Author

No test needed, only story changed

@werdnanoslen
Copy link
Contributor Author

The address template will need to be updated once #2524 is merged, so please merge that one first.

</abbr>
).
</p>
<Label htmlFor="mailing-address-1">Street address</Label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Should Street Address be marked as required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessarily, i was just copying the USWDS example

@werdnanoslen werdnanoslen enabled auto-merge (squash) July 26, 2023 00:01
@werdnanoslen werdnanoslen merged commit e1c60cb into main Jul 26, 2023
@werdnanoslen werdnanoslen deleted the an-storybook-2519 branch July 26, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Storybook updates to match updated USWDS recs
2 participants