feat: replaced memorable date month input with select #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werdnanoslen
requested review from
gidjin,
haworku,
ahobson,
brandonlenz and
SirenaBorracha
as code owners
|
This was only an update to the story, so no testing needed |
brandonlenz
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Happo looks good. I suggest the following for an actual component to add to ReactUSWDS as a future iteration on this: #2632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces text input with a Select input for month in memorable date (AKA date input group)
Related Issues or PRs
Resolves #2520
How To Test
Screenshots (optional)